This diff simply adds the Tag Farcaster channel option to the CommunityActionsMenu if the conditions are met (user has fid, they have the necessary permissions, and the community is not a GENESIS community)
Depends on D12567
Details
Details
Confirmed that this option is only present if the conditions mentioned above are met. Also please see screenshot below
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Comment Actions
Passing back to factor out the check. We should avoid copy-pasting code, especially when it's related to things like permissions. It makes it way more likely that somebody fails to update some copy-pasted conditional at a later point
| web/components/community-actions-menu.react.js | ||
|---|---|---|
| 55–58 ↗ | (On Diff #41676) | Does this check exist anywhere else, eg. native? If so, can you factor it out please? |
| 110 ↗ | (On Diff #41676) | Do we have a similar need for an icon on native, and if so what icon we're using? |
| web/components/community-actions-menu.react.js | ||
|---|---|---|
| 110 ↗ | (On Diff #41676) | On native we use an action sheet and none of the options use an icon |