Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 25, 9:33 PM

	Unknown Object (File)
	Wed, Sep 25, 9:33 PM

	Unknown Object (File)
	Wed, Sep 25, 9:33 PM

	Unknown Object (File)
	Wed, Sep 25, 9:32 PM

	Unknown Object (File)
	Wed, Sep 25, 9:32 PM

	Unknown Object (File)
	Sep 1 2024, 8:56 AM

	Unknown Object (File)
	Aug 27 2024, 5:28 PM

	Unknown Object (File)
	Aug 26 2024, 3:21 PM

View All 55 Files

Subscribers

ashoat

tomek

Details

Reviewers

kamil
varun
will

Commits

rCOMM9e9735538ea8: [identity] Rename verify_initial_device_list to verify_singleton_device_list

Summary

Similarly to the rename in D12586, this makes the function more universal because in fact it verifies singleton list (not necessarily initial).

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 27 2024, 7:26 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2024, 7:26 AM

bartek added a child revision: D12588: [identity] Add function to remove user devices' data.Jun 27 2024, 7:29 AM

Rebase

Harbormaster failed remote builds in B29952: Diff 41749!Jun 27 2024, 7:54 AM

bartek published this revision for review.Jun 27 2024, 7:59 AM

Harbormaster completed remote builds in B29958: Diff 41755.Jun 27 2024, 8:30 AM

varun accepted this revision.Jun 28 2024, 10:48 AM

This revision is now accepted and ready to land.Jun 28 2024, 10:48 AM

kamil accepted this revision.Jul 1 2024, 3:02 AM

Closed by commit rCOMM9e9735538ea8: [identity] Rename verify_initial_device_list to verify_singleton_device_list (authored by bartek). · Explain WhyJul 2 2024, 11:53 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9e9735538ea8: [identity] Rename verify_initial_device_list to verify_singleton_device_list.

[identity] Rename verify_initial_device_list to verify_singleton_device_list
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41927

services/identity/src/device_list.rs

services/identity/src/grpc_utils.rs

[identity] Rename verify_initial_device_list to verify_singleton_device_listClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41927

services/identity/src/device_list.rs

services/identity/src/grpc_utils.rs

[identity] Rename verify_initial_device_list to verify_singleton_device_list
ClosedPublic
Actions

Revision Contents
Changeset List