[terraform] restrict redis access to ecs keyserver service only
ClosedPublic
Actions

Authored by will on Jul 8 2024, 5:39 AM.

Details

Reviewers

varun
bartek

Commits

rCOMM5d1bab441ea1: [terraform] restrict redis access to ecs keyserver service only

Summary

Now that we have a keyserver security group, we can specify the keyserver security group as the restriction in our ingress rule instead of universal access to the redis instance.

Depends on D12689

Test Plan

terraform apply

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 8 2024, 5:39 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 8 2024, 5:39 AM

will edited the summary of this revision. (Show Details)Jul 8 2024, 5:39 AM

will added a parent revision: D12689: [terraform] create comm database on aws rds startup.

will added a child revision: D12691: [terraform] include REDIS_URL as part of keyserver terraform config.Jul 8 2024, 5:42 AM

Harbormaster completed remote builds in B30194: Diff 42106.Jul 8 2024, 5:56 AM

will requested review of this revision.Jul 8 2024, 5:56 AM

varun accepted this revision.Jul 11 2024, 12:17 AM

This revision is now accepted and ready to land.Jul 11 2024, 12:17 AM

Closed by commit rCOMM5d1bab441ea1: [terraform] restrict redis access to ecs keyserver service only (authored by will). · Explain WhyJul 17 2024, 7:01 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM5d1bab441ea1: [terraform] restrict redis access to ecs keyserver service only.

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

aws_elasticache.tf

8 lines

Diff 42106

View Options

services/terraform/self-host/aws_elasticache.tf

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Lines	export type UpdateConnectionStatusPayload = {
+status: ConnectionStatus,		+status: ConnectionStatus,
+keyserverID: string,		+keyserverID: string,
};		};

export const setLateResponseActionType = 'SET_LATE_RESPONSE';		export const setLateResponseActionType = 'SET_LATE_RESPONSE';
export type SetLateResponsePayload = {		export type SetLateResponsePayload = {
+messageID: number,		+messageID: number,
+isLate: boolean,		+isLate: boolean,
		+keyserverID: string,
};		};

export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR';		export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR';
export type UpdateDisconnectedBarPayload = { +visible: boolean };		export type UpdateDisconnectedBarPayload = {
		+visible: boolean,
		+keyserverID: string,
		};

export type OneTimeKeyGenerator = (inc: number) => string;		export type OneTimeKeyGenerator = (inc: number) => string;

export type GRPCStream = {		export type GRPCStream = {
readyState: number,		readyState: number,
onopen: (ev: any) => mixed,		onopen: (ev: any) => mixed,
onmessage: (ev: MessageEvent) => mixed,		onmessage: (ev: MessageEvent) => mixed,
onclose: (ev: CloseEvent) => mixed,		onclose: (ev: CloseEvent) => mixed,
close(code?: number, reason?: string): void,		close(code?: number, reason?: string): void,
send(data: string \| Blob \| ArrayBuffer \| $ArrayBufferView): void,		send(data: string \| Blob \| ArrayBuffer \| $ArrayBufferView): void,
};		};

export type CommTransportLayer = GRPCStream \| WebSocket;		export type CommTransportLayer = GRPCStream \| WebSocket;

[terraform] restrict redis access to ecs keyserver service onlyClosedPublicActions