Paths

Table of Contentst

Differential D12717

[web] introduce AutoJoinCommunityHandler to web
ClosedPublic
Actions

Authored by ginsu on Jul 10 2024, 2:58 AM.

Tags

None

Referenced Files

	F2717456: D12717.diff
	Mon, Sep 16, 8:31 AM

	F2714737: D12717.id42204.diff
	Mon, Sep 16, 2:05 AM

	Unknown Object (File)
	Sun, Sep 15, 10:06 AM

	Unknown Object (File)
	Sun, Sep 15, 10:06 AM

	Unknown Object (File)
	Sun, Sep 15, 3:36 AM

	Unknown Object (File)
	Sat, Aug 31, 3:09 PM

	Unknown Object (File)
	Wed, Aug 28, 11:07 AM

	Unknown Object (File)
	Mon, Aug 26, 2:03 PM

View All 46 Files

Subscribers

Details

Reviewers

ashoat
inka

Commits

rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web

Summary

This diff simply introduces the version of AutoJoinCommunityHandler for web

Depends on D12716

Test Plan

Confirmed that the auto join community mechanism also works on web

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jul 10 2024, 2:58 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 10 2024, 2:58 AM

ginsu edited the summary of this revision. (Show Details)Jul 10 2024, 2:59 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12716: [lib/native] lift auto join community handler to lib.

Harbormaster completed remote builds in B30263: Diff 42204.Jul 10 2024, 3:20 AM

ginsu requested review of this revision.Jul 10 2024, 3:20 AM

ginsu edited the summary of this revision. (Show Details)Jul 10 2024, 3:37 AM

ashoat accepted this revision.Jul 10 2024, 10:39 AM

ashoat added inline comments.

web/components/auto-join-community-handler.react.js
8 ↗	(On Diff #42204)	What's `nonThread` mean here again? Exclusing sidebars?

This revision is now accepted and ready to land.Jul 10 2024, 10:39 AM

ginsu added inline comments.Jul 12 2024, 5:46 PM

web/components/auto-join-community-handler.react.js
8 ↗	(On Diff #42204)	It seems like we are using this to filter out all the calendar filters with the type `THREAD_LIST` from an array of calendar filters. So it looks like "nonThread" refers to any calendar query that are not related to threads https://github.com/CommE2E/comm/blob/master/lib/selectors/calendar-filter-selectors.js#L36-L60

rebase before landing

This revision was landed with ongoing or failed builds.Jul 12 2024, 5:48 PM

Closed by commit rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web.

Harbormaster completed remote builds in B30307: Diff 42264.Jul 12 2024, 6:04 PM

Revision Contents
Changeset List

Path

Size

web/

2 lines

components/

auto-join-community-handler.react.js

16 lines

Diff 42264

web/app.react.js

Loading...

web/components/auto-join-community-handler.react.js

Loading...