Page MenuHomePhabricator
Differential D12339

[terraform] Use default vpc, subnets, and internet gateway for self-host
ClosedPublic
Actions

Authored by will on Jun 6 2024, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 11, 7:22 PM
Unknown Object (File)
Fri, Oct 11, 7:22 PM
Unknown Object (File)
Fri, Oct 11, 7:05 PM
Unknown Object (File)
Fri, Oct 11, 7:02 PM
Unknown Object (File)
Tue, Oct 8, 7:52 PM
Unknown Object (File)
Wed, Oct 2, 3:04 AM
Unknown Object (File)
Sun, Sep 29, 3:48 AM
Unknown Object (File)
Sat, Sep 28, 11:34 PM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM5391d6ca6ca6: [terraform] Use default vpc, subnets, and internet gateway for self-host
Summary

This removes the need to specify availability zones by using the vpc, subnets, and internet gateway default to each region.

Depends on D12324

Test Plan

Deployed set up to region specified in config. Mariadb database was accessible.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Jun 6 2024, 8:37 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2024, 8:37 PM
Harbormaster completed remote builds in B29504: Diff 41077.Jun 6 2024, 8:57 PM
will requested review of this revision.Jun 6 2024, 8:57 PM
will updated this revision to Diff 41082.Jun 6 2024, 9:15 PM

remove availability zones

Harbormaster completed remote builds in B29509: Diff 41082.Jun 6 2024, 9:36 PM
bartek accepted this revision.Jun 7 2024, 1:44 AM
This revision is now accepted and ready to land.Jun 7 2024, 1:44 AM
will added a child revision: D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.Jul 11 2024, 2:39 PM
will updated this revision to Diff 42258.Jul 12 2024, 10:26 AM

Add option for user created vpc to avoid migration of prod aws rds instance to new vpc

Harbormaster completed remote builds in B30303: Diff 42258.Jul 12 2024, 10:43 AM
will updated this revision to Diff 42356.Jul 16 2024, 11:35 AM

typo

Harbormaster completed remote builds in B30393: Diff 42356.Jul 16 2024, 11:51 AM
will updated this revision to Diff 42362.Jul 16 2024, 3:00 PM

only create vpc, subnets, and internet gateway if user created option is true

Harbormaster completed remote builds in B30399: Diff 42362.Jul 16 2024, 3:17 PM
Closed by commit rCOMM5391d6ca6ca6: [terraform] Use default vpc, subnets, and internet gateway for self-host (authored by will). · Explain WhyJul 17 2024, 3:29 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM5391d6ca6ca6: [terraform] Use default vpc, subnets, and internet gateway for self-host.

Revision Contents
Changeset List

PathSize
services/
terraform/
self-host/
3 lines
38 lines
5 lines
2 lines
10 lines

Diff 42356

View Options

services/terraform/self-host/aws_db.tf

Loading...
View Options

services/terraform/self-host/aws_vpc.tf

Loading...
View Options

services/terraform/self-host/main.tf

Loading...
View Options

services/terraform/self-host/terraform.tfvars.example

Loading...
View Options

services/terraform/self-host/variables.tf

Loading...