Page MenuHomePhabricator
Differential D12457

[terraform] Upgrade AWS Terraform provider to 5.32.0
ClosedPublic
Actions

Authored by will on Jun 17 2024, 9:07 PM.
Tags
None
Referenced Files
F5106491: D12457.id41426.diff
Tue, Apr 1, 8:46 AM
Unknown Object (File)
Tue, Apr 1, 12:13 AM
Unknown Object (File)
Wed, Mar 12, 2:11 PM
Unknown Object (File)
Tue, Mar 4, 1:47 PM
Unknown Object (File)
Feb 22 2025, 6:33 AM
Unknown Object (File)
Feb 22 2025, 6:33 AM
Unknown Object (File)
Feb 22 2025, 6:33 AM
Unknown Object (File)
Feb 22 2025, 6:33 AM
View All 68 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM7c8726a6d4fe: [terraform] Upgrade AWS Terraform provider to 5.32.0
Summary

AWS Elasticache serverless requires AWS provider version 5.32.0 or above.

Depends on D12339

Test Plan

Successful terraform apply

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Jun 17 2024, 9:07 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 17 2024, 9:07 PM
will edited the test plan for this revision. (Show Details)Jun 17 2024, 9:07 PM
will added a child revision: D12458: [terraform] initial Redis terraform config.Jun 17 2024, 9:12 PM
Harbormaster completed remote builds in B29731: Diff 41426.Jun 17 2024, 9:23 PM
will requested review of this revision.Jun 17 2024, 9:23 PM
bartek accepted this revision.Jun 17 2024, 11:47 PM
This revision is now accepted and ready to land.Jun 17 2024, 11:47 PM
ashoat added a comment.Jun 18 2024, 9:51 AM

Why not the latest version?

will added a comment.Jun 18 2024, 10:00 AM
In D12457#353784, @ashoat wrote:

Why not the latest version?

We definitely can. I was just trying to keep the versioning closer to our current aws provider version

will edited the summary of this revision. (Show Details)Jul 11 2024, 2:39 PM
will added a parent revision: D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.
Closed by commit rCOMM7c8726a6d4fe: [terraform] Upgrade AWS Terraform provider to 5.32.0 (authored by will). · Explain WhyJul 17 2024, 3:29 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM7c8726a6d4fe: [terraform] Upgrade AWS Terraform provider to 5.32.0.

Revision Contents
Changeset List

PathSize
services/
terraform/
self-host/
2 lines

Diff 42422

View Options

services/terraform/self-host/providers.tf

// @flow // @flow
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import { createSelector } from 'reselect';
import t from 'tcomb'; import t from 'tcomb';
import type { StateSyncSpec } from './state-sync-spec.js'; import type { StateSyncSpec } from './state-sync-spec.js';
import { import {
type CalendarQuery, type CalendarQuery,
type RawEntryInfos, type RawEntryInfos,
rawEntryInfoValidator, rawEntryInfoValidator,
type RawEntryInfo, type RawEntryInfo,
} from '../../types/entry-types.js'; } from '../../types/entry-types.js';
import type { AppState } from '../../types/redux-types.js';
import { import {
reportTypes, reportTypes,
type ClientEntryInconsistencyReportCreationRequest, type ClientEntryInconsistencyReportCreationRequest,
} from '../../types/report-types.js'; } from '../../types/report-types.js';
import type { ProcessServerRequestAction } from '../../types/request-types.js'; import type { ProcessServerRequestAction } from '../../types/request-types.js';
import { actionLogger } from '../../utils/action-logger.js'; import { actionLogger } from '../../utils/action-logger.js';
import { getConfig } from '../../utils/config.js'; import { getConfig } from '../../utils/config.js';
import { convertClientIDsToServerIDs } from '../../utils/conversion-utils.js'; import { convertClientIDsToServerIDs } from '../../utils/conversion-utils.js';
import { values } from '../../utils/objects.js'; import { values, combineUnorderedHashes, hash } from '../../utils/objects.js';
import { generateReportID } from '../../utils/report-utils.js'; import { generateReportID } from '../../utils/report-utils.js';
import { sanitizeActionSecrets } from '../../utils/sanitization.js'; import { sanitizeActionSecrets } from '../../utils/sanitization.js';
import { ashoatKeyserverID, tID } from '../../utils/validation-utils.js'; import { ashoatKeyserverID, tID } from '../../utils/validation-utils.js';
import { import {
filterRawEntryInfosByCalendarQuery, filterRawEntryInfosByCalendarQuery,
serverEntryInfosObject, serverEntryInfosObject,
} from '../entry-utils.js'; } from '../entry-utils.js';
▲ Show 20 Lines • Show All 52 Lines • ▼ Show 20 Lines return [
calendarQuery, calendarQuery,
pushResult: afterStateCheck, pushResult: afterStateCheck,
lastActions: actionLogger.interestingActionSummaries, lastActions: actionLogger.interestingActionSummaries,
time: Date.now(), time: Date.now(),
id: generateReportID(), id: generateReportID(),
}, },
]; ];
}, },
selector: createSelector(
(state: AppState) => state.entryStore.entryInfos,
entryInfos => ({
...entriesStateSyncSpec,
getInfoHash: id => hash(entryInfos[`${ashoatKeyserverID}|${id}`]),
getAllInfosHash: calendarQuery =>
getEntryInfosHash(entryInfos, calendarQuery),
getIDs: calendarQuery => getEntryIDs(entryInfos, calendarQuery),
}),
),
}); });
const emptyArray = []; const emptyArray = [];
function getEntryInfosHash(
entryInfos: RawEntryInfos,
calendarQuery: CalendarQuery,
) {
const filteredEntryInfos = filterRawEntryInfosByCalendarQuery(
serverEntryInfosObject(values(entryInfos)),
calendarQuery,
);
return combineUnorderedHashes(Object.values(filteredEntryInfos).map(hash));
}
function getEntryIDs(entryInfos: RawEntryInfos, calendarQuery: CalendarQuery) {
const filteredEntryInfos = filterRawEntryInfosByCalendarQuery(
serverEntryInfosObject(values(entryInfos)),
calendarQuery,
);
return Object.keys(filteredEntryInfos).map(id => id.split('|')[1]);
}