Details

Reviewers

kamil
marcin

Commits

rCOMM51d27bec0c9b: Add a new field to OutboundP2PMessage

Summary

Some boilerplate for writing and reading the field from D12742.

https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms

Depends on D12742

Test Plan

Tested later in the stack by checking if the message with this field can be saved and read.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 15 2024, 3:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 3:49 AM

tomek edited the summary of this revision. (Show Details)Jul 15 2024, 3:50 AM

tomek added a parent revision: D12742: [SQLite] Add a new column to outbound_p2p_messages table.

tomek added a child revision: D12744: [native][web] Add a method fetching messages by ID.Jul 15 2024, 4:05 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 4:26 AM

Harbormaster failed remote builds in B30320: Diff 42281!

Harbormaster completed remote builds in B30320: Diff 42281.Jul 16 2024, 3:34 AM

tomek requested review of this revision.Jul 16 2024, 3:34 AM

kamil accepted this revision.Jul 16 2024, 3:40 AM

This revision is now accepted and ready to land.Jul 16 2024, 3:40 AM

Rename

Harbormaster completed remote builds in B30377: Diff 42340.Jul 16 2024, 5:01 AM

Return boolean value

Harbormaster completed remote builds in B30408: Diff 42379.Jul 17 2024, 5:44 AM

Rebase

Harbormaster completed remote builds in B30415: Diff 42387.Jul 17 2024, 9:34 AM

Closed by commit rCOMM51d27bec0c9b: Add a new field to OutboundP2PMessage (authored by tomek). · Explain WhyJul 19 2024, 7:47 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM51d27bec0c9b: Add a new field to OutboundP2PMessage.

Add a new field to OutboundP2PMessage
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42539

lib/types/sqlite-types.js

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/OutboundP2PMessage.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm-query-executor.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Add a new field to OutboundP2PMessageClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42539

lib/types/sqlite-types.js

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/OutboundP2PMessage.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm-query-executor.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Add a new field to OutboundP2PMessage
ClosedPublic
Actions

Revision Contents
Changeset List