Paths

Table of Contentst

Differential D12745

[native][web] Introduce a method fetching messages by ID to SQLiteAPI
ClosedPublic
Actions

Authored by tomek on Jul 15 2024, 4:13 AM.

Tags

None

Referenced Files

	F3149453: D12745.id42390.diff
	Mon, Nov 4, 2:04 PM

	Unknown Object (File)
	Sun, Nov 3, 5:27 AM

	Unknown Object (File)
	Thu, Oct 24, 12:52 AM

	Unknown Object (File)
	Wed, Oct 23, 9:54 PM

	Unknown Object (File)
	Wed, Oct 23, 10:23 AM

	Unknown Object (File)
	Tue, Oct 22, 9:30 AM

	Unknown Object (File)
	Tue, Oct 22, 6:05 AM

	Unknown Object (File)
	Fri, Oct 18, 10:29 PM

View All 88 Files

Subscribers

Details

Reviewers

kamil
marcin

Commits

rCOMM98cf024dada2: [native][web] Introduce a method fetching messages by ID to SQLiteAPI

Summary

This method will be used to handle manual retries.

https://linear.app/comm/issue/ENG-8675/add-option-to-manually-retry-a-message

Depends on D12744

Test Plan

Tested in combination with the rest of the stack. Sending messages requires calling this API so checking if messages are sent tests it.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 15 2024, 4:13 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 4:13 AM

tomek added a child revision: D12746: [lib] Disable automatic retries of all messages and enable manual retries.Jul 15 2024, 4:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 4:38 AM

Harbormaster failed remote builds in B30322: Diff 42283!

Rebase

Harbormaster completed remote builds in B30379: Diff 42342.Jul 16 2024, 5:14 AM

tomek requested review of this revision.Jul 16 2024, 5:14 AM

ashoat added inline comments.Jul 16 2024, 6:50 AM

lib/types/sqlite-types.js
42–43 ↗	(On Diff #42342)	Looks like there was a typo here and the `s` at the end was left out (it's included in other uses of this name)

Rebase

Harbormaster completed remote builds in B30418: Diff 42390.Jul 17 2024, 8:55 AM

tomek edited the test plan for this revision. (Show Details)Jul 17 2024, 9:21 AM

kamil accepted this revision.Jul 18 2024, 6:23 AM

kamil added inline comments.

lib/types/sqlite-types.js
48 ↗	(On Diff #42390)	I prefer to return `OutboundP2PMessage[]` here but up to you
42–43 ↗	(On Diff #42342)	Looks like there was a typo here and the `s` at the end was left out (it's included in other uses of this name) Yeah, this is my oversight
web/types/worker-types.js
199 ↗	(On Diff #42390)	TO avoid confusing with `GetOutboundP2PMessagesRequestMessage` above

This revision is now accepted and ready to land.Jul 18 2024, 6:23 AM

Update types and names

lib/types/sqlite-types.js
48 ↗	(On Diff #42390)	`OutboundP2PMessage[]` syntax is recommended to be avoided by Flow. But we can use `Array<OutboundP2PMessage>`
42–43 ↗	(On Diff #42342)	Will put up a separate diff fixing it
web/types/worker-types.js
199 ↗	(On Diff #42390)	Makes sense!

Harbormaster completed remote builds in B30475: Diff 42474.Jul 18 2024, 8:38 AM

Closed by commit rCOMM98cf024dada2: [native][web] Introduce a method fetching messages by ID to SQLiteAPI (authored by tomek). · Explain WhyJul 19 2024, 7:47 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM98cf024dada2: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.

tomek added inline comments.Jul 19 2024, 8:38 AM

lib/types/sqlite-types.js
42–43 ↗	(On Diff #42342)	Fixed in D12804

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

11 lines

utils/

__mocks__/

1 line

native/

database/

1 line

schema/

CommCoreModuleSchema.js

2 lines

web/

database/

14 lines

shared-worker/

worker/

shared-worker.js

9 lines

types/

worker-types.js

9 lines

Diff 42541

lib/types/sqlite-types.js

Loading...

lib/utils/mocks/config.js

Loading...

native/database/sqlite-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

web/database/sqlite-api.js

Loading...

web/shared-worker/worker/shared-worker.js

Loading...

web/types/worker-types.js

Loading...