Page MenuHomePhabricator

[lib] Disable automatic retries of all messages and enable manual retries
ClosedPublic

Authored by tomek on Jul 15 2024, 4:20 AM.
Tags
None
Referenced Files
F3368569: D12746.id42343.diff
Mon, Nov 25, 8:16 PM
Unknown Object (File)
Wed, Nov 20, 2:07 PM
Unknown Object (File)
Wed, Nov 20, 2:07 PM
Unknown Object (File)
Wed, Nov 20, 2:06 PM
Unknown Object (File)
Sat, Nov 9, 8:45 AM
Unknown Object (File)
Fri, Nov 8, 10:39 PM
Unknown Object (File)
Fri, Nov 8, 12:26 PM
Unknown Object (File)
Fri, Nov 8, 2:24 AM
Subscribers

Details

Summary

Modify processOutboundMessages function so that it accepts an optional parameter with a list of message IDs. When this parameter is set, we try to send only these messages - this version is used for both initial send and for a manual retry. When the parameter isn't set, we try to send all the messages (this behavior is changed in the next diff).

https://linear.app/comm/issue/ENG-8676/stop-automatic-retries-of-dms
https://linear.app/comm/issue/ENG-8675/add-option-to-manually-retry-a-message

Depends on D12745

Test Plan

Tested on both native and web: modified our text message sending logic so that DMOps are generated and scheduled when we send a message:

  1. Sent a message and checked if sending messages was attempted.
  2. Modified the logic in processOutboundP2PMessages so that every other message fails. Checked if the retry was attempted after 30s.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable