Details
- Have a few users registered to identity
- Manually added a few items to the reserved usernames table.
- Call the RPC with user IDs from both tables, and also a few non-existent IDs
- Verify that response contains usernames for both types of users
Also verified that previous methods that base on modified DatabaseClient::query_reserved_usernames_table() work the same way as before.
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
services/identity/src/database.rs | ||
---|---|---|
1259–1265 | Introduced this to be able to monitor how big the numbers actually are and if we need to worry about performance | |
1267–1277 | Decided to do a traditional for loop instead of spawning threads, to avoid issues similar to our last OOM incident. Unfortunately, we cannot do anything like BatchGet here because we're querying an index. | |
services/identity/src/grpc_services/authenticated.rs | ||
875–880 | I hope this will limit the number of queried user IDs over time. The more users registered on Identity we have, the less users will stay in the reserved usernames table |