[lib][native][web] Extend findUserIdentities response type
ClosedPublic
Actions

Authored by bartek on Jul 29 2024, 11:43 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMMef5dbcde24ae: [lib][native][web] Extend findUserIdentities response type

Summary

Updated Flow types and validators to include extended response of the FindUserIdentities RPC.
Kept previous logic, I didn't made any use of the new extended response.

Depends on D12925

Test Plan

Flow, repeated test plan from D12925 (generally played with modified functions). Made sure they work as before

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 29 2024, 11:43 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJul 29 2024, 11:43 AM

Harbormaster completed remote builds in B30771: Diff 42914.Jul 29 2024, 12:03 PM

bartek published this revision for review.Jul 29 2024, 12:04 PM

Makes sense. I think we'll need to update the two handler components here to look at the newly-returned reservedUserIdentities property, but my impression is that this will be handled by @inka in a later diff

This revision is now accepted and ready to land.Jul 30 2024, 10:57 PM

Rename to reservedUserIdentifiers

In D12926#366075, @ashoat wrote:

I think we'll need to update the two handler components here to look at the newly-returned reservedUserIdentities property, but my impression is that this will be handled by @inka in a later diff

Yeah, I think that's the plan

Harbormaster completed remote builds in B30829: Diff 42982.Jul 31 2024, 1:59 AM

Closed by commit rCOMMef5dbcde24ae: [lib][native][web] Extend findUserIdentities response type (authored by bartek). · Explain WhyJul 31 2024, 2:07 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMef5dbcde24ae: [lib][native][web] Extend findUserIdentities response type.