Page MenuHomePhabricator
Differential D12946

[Tunnelbroker] invalidate bad Web Push tokens
ClosedPublic
Actions

Authored by kamil on Jul 30 2024, 6:06 AM.
Tags
None
Referenced Files
F3203313: D12946.diff
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Wed, Nov 6, 11:03 PM
Unknown Object (File)
Sat, Nov 2, 3:44 AM
Unknown Object (File)
Thu, Oct 24, 9:14 PM
Unknown Object (File)
Thu, Oct 24, 9:14 PM
Unknown Object (File)
Sat, Oct 19, 8:24 AM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
View All 57 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMM2960f788547e: [Tunnelbroker] invalidate bad Web Push tokens
Summary

ENG-8498.

Based on keyserver error codes.
Here is library mapping of status to errors used in this diff.

Depends on D12911

Test Plan

Manually malform device token for web device in DDB (url in JSON), try sending notif to this device and verify that flag was flipped and the message was sent to the device (both online and offline device).

Diff Detail

Repository
rCOMM Comm
Branch
land-final-stack
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 30 2024, 6:06 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 30 2024, 6:06 AM
kamil published this revision for review.Jul 30 2024, 6:18 AM
Harbormaster completed remote builds in B30816: Diff 42969.Jul 30 2024, 7:15 AM
bartek accepted this revision.Jul 30 2024, 7:53 AM
bartek added inline comments.
services/tunnelbroker/src/websockets/session.rs
519–537 ↗(On Diff #42969)

maybe doing sth like

use notifs::web_push::error::Error as NotifError;
use web_push::WebPushError;

locally here in this function, it could make these lines shorter

This revision is now accepted and ready to land.Jul 30 2024, 7:53 AM
kamil added a child revision: D12951: [Tunnelbroker] invalidate bad FCM tokens.Jul 31 2024, 2:49 AM
kamil updated this revision to Diff 42996.Jul 31 2024, 6:40 AM

address review

Harbormaster completed remote builds in B30838: Diff 42996.Jul 31 2024, 7:02 AM
Closed by commit rCOMM2960f788547e: [Tunnelbroker] invalidate bad Web Push tokens (authored by kamil). · Explain WhyJul 31 2024, 7:14 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2960f788547e: [Tunnelbroker] invalidate bad Web Push tokens.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
web_push/
2 lines
websockets/
37 lines

Diff 42996

View Options

services/tunnelbroker/src/notifs/web_push/mod.rs

Loading...
View Options

services/tunnelbroker/src/websockets/session.rs

Loading...