Page MenuHomePhabricator
Differential D12996

[lib] Use the useBroadcastOlmMessage hook in account deletion
ClosedPublic
Actions

Authored by bartek on Aug 6 2024, 1:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 1:54 PM
Unknown Object (File)
Mar 3 2025, 3:46 PM
Unknown Object (File)
Feb 18 2025, 5:14 AM
Unknown Object (File)
Feb 18 2025, 5:14 AM
Unknown Object (File)
Feb 18 2025, 5:13 AM
Unknown Object (File)
Feb 3 2025, 12:34 PM
Unknown Object (File)
Jan 30 2025, 1:53 PM
Unknown Object (File)
Jan 26 2025, 12:19 PM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion
Summary

Updated useBroadcastAccountDeletion to use the new useBroadcastOlmMessage hook.
Also renamed broadcastToOwnDevices to includeOwnDevices because the old name was confusing.

Depends on D12994, D12995

Test Plan

Repeated test plan from D12944

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 6 2024, 1:04 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 6 2024, 1:04 AM
bartek added a child revision: D12997: [lib] Use the useBroadcastOlmMessage hook in logout actions.Aug 6 2024, 1:06 AM
Harbormaster completed remote builds in B30951: Diff 43166.Aug 6 2024, 1:26 AM
bartek published this revision for review.Aug 6 2024, 1:36 AM
bartek added inline comments.
lib/hooks/peer-list-hooks.js
216–218
kamil accepted this revision.Aug 6 2024, 2:47 AM
kamil added inline comments.
lib/hooks/peer-list-hooks.js
216–218

nice, I think it's better now

This revision is now accepted and ready to land.Aug 6 2024, 2:47 AM
bartek updated this revision to Diff 43173.Aug 6 2024, 4:30 AM

Rebase on moved hook

Harbormaster completed remote builds in B30955: Diff 43173.Aug 6 2024, 4:53 AM
Closed by commit rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion (authored by bartek). · Explain WhyAug 6 2024, 5:18 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion.

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines
hooks/
71 lines
tunnelbroker/
2 lines

Diff 43166

View Options

lib/actions/user-actions.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines
View Options

lib/hooks/peer-list-hooks.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines