Paths

Table of Contentst

Differential D13010

Update db ops reducer to process notiications creation data
ClosedPublic
Actions

Authored by marcin on Aug 7 2024, 9:30 AM.

Tags

None

Referenced Files

	F3301795: D13010.diff
	Mon, Nov 18, 4:14 AM

	Unknown Object (File)
	Sun, Nov 10, 7:20 AM

	Unknown Object (File)
	Sat, Nov 9, 9:14 PM

	Unknown Object (File)
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 12:22 PM

	Unknown Object (File)
	Sun, Nov 3, 5:04 PM

	Unknown Object (File)
	Mon, Oct 28, 1:32 PM

	Unknown Object (File)
	Oct 18 2024, 5:17 PM

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMa1413b25eba8: Update db ops reducer to process notiications creation data

Summary

This differential implements the logic described in the Linear issue description: https://linear.app/comm/issue/ENG-8284/send-encrypted-notification-from-the-client-to-the-tb. This code lies foundation to automatically send e2ee notifs if relevant DMOperationSpec implements notificationsCreationData method

Test Plan

tested with the child diff

Diff Detail

Repository

Branch

marcin/eng-8237

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 7 2024, 9:30 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 7 2024, 9:30 AM

marcin added a parent revision: D12882: Implement sending E2EE notification from the client.Aug 7 2024, 9:31 AM

marcin added a child revision: D13011: Implement notificationsCreationData for send-text-message-spec.Aug 7 2024, 9:38 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 9:48 AM

Harbormaster failed remote builds in B30982: Diff 43222!

marcin requested review of this revision.Aug 7 2024, 9:51 AM

Add db ops store action to schedule notifications creation and sending. Make db ops reducer aware of this new action

marcin added a child revision: D13048: Implement utilities to go from RawMessageInfo to MessageData.Aug 12 2024, 6:49 AM

Harbormaster completed remote builds in B31043: Diff 43307.Aug 12 2024, 7:24 AM

marcin edited child revisions, added: D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs; removed: D13048: Implement utilities to go from RawMessageInfo to MessageData, D13011: Implement notificationsCreationData for send-text-message-spec.Aug 20 2024, 7:31 AM

Reorder teh stack

marcin removed a parent revision: D12882: Implement sending E2EE notification from the client.Aug 21 2024, 10:09 AM

marcin removed a child revision: D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.

marcin added a parent revision: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.

marcin added a child revision: D13123: Update sendDMOperation to send notifs as well.

Harbormaster completed remote builds in B31203: Diff 43557.Aug 21 2024, 10:24 AM

Update queueDBOps to queue notificationsCreationData

Harbormaster completed remote builds in B31283: Diff 43675.Aug 27 2024, 5:57 AM

kamil added inline comments.Aug 27 2024, 8:03 AM

lib/types/db-ops-types.js
15–16 ↗	(On Diff #43675)	this is not needed, `dmOpID` is part of `DispatchMetadata`
native/redux/redux-setup.js
317–328 ↗	(On Diff #43675)	see me comment below how to simplify this
web/redux/redux-setup.js
543–563 ↗	(On Diff #43675)	I think this can be simplified?

Address review

Harbormaster completed remote builds in B31294: Diff 43695.Aug 27 2024, 8:58 AM

kamil accepted this revision.Aug 27 2024, 10:35 AM

This revision is now accepted and ready to land.Aug 27 2024, 10:35 AM

Rebase before landing

Harbormaster completed remote builds in B31306: Diff 43707.Aug 27 2024, 11:23 AM

Closed by commit rCOMMa1413b25eba8: Update db ops reducer to process notiications creation data (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyAug 27 2024, 11:30 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMa1413b25eba8: Update db ops reducer to process notiications creation data.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

db-ops-reducer.js

2 lines

shared/

dm-ops/

2 lines

tunnelbroker/

peer-to-peer-context.js

10 lines

types/

2 lines

Diff 43222

lib/reducers/db-ops-reducer.js

Loading...

lib/shared/dm-ops/dm-op-spec.js

Loading...

lib/tunnelbroker/peer-to-peer-context.js

Loading...

lib/types/dm-ops.js

Loading...