Page MenuHomePhabricator
Differential D13010

Update db ops reducer to process notiications creation data
ClosedPublic
Actions

Authored by marcin on Aug 7 2024, 9:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 8:31 AM
Unknown Object (File)
Thu, Mar 20, 8:24 PM
Unknown Object (File)
Mon, Mar 17, 5:33 AM
Unknown Object (File)
Mar 11 2025, 2:41 PM
Unknown Object (File)
Mar 5 2025, 4:52 PM
Unknown Object (File)
Mar 2 2025, 3:27 PM
Unknown Object (File)
Feb 25 2025, 6:19 PM
Unknown Object (File)
Feb 17 2025, 10:44 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMa1413b25eba8: Update db ops reducer to process notiications creation data
Summary

This differential implements the logic described in the Linear issue description: https://linear.app/comm/issue/ENG-8284/send-encrypted-notification-from-the-client-to-the-tb. This code lies foundation to automatically send e2ee notifs if relevant DMOperationSpec implements notificationsCreationData method

Test Plan

tested with the child diff

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-8237
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Aug 7 2024, 9:30 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 7 2024, 9:30 AM
marcin added a parent revision: D12882: Implement sending E2EE notification from the client.Aug 7 2024, 9:31 AM
marcin added a child revision: D13011: Implement notificationsCreationData for send-text-message-spec.Aug 7 2024, 9:38 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 9:48 AM
Harbormaster failed remote builds in B30982: Diff 43222!
marcin requested review of this revision.Aug 7 2024, 9:51 AM
marcin updated this revision to Diff 43307.Aug 12 2024, 6:46 AM

Add db ops store action to schedule notifications creation and sending. Make db ops reducer aware of this new action

marcin added a child revision: D13048: Implement utilities to go from RawMessageInfo to MessageData.Aug 12 2024, 6:49 AM
Harbormaster completed remote builds in B31043: Diff 43307.Aug 12 2024, 7:24 AM
marcin edited child revisions, added: D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs; removed: D13048: Implement utilities to go from RawMessageInfo to MessageData, D13011: Implement notificationsCreationData for send-text-message-spec.Aug 20 2024, 7:31 AM
marcin updated this revision to Diff 43557.Aug 21 2024, 10:07 AM

Reorder teh stack

marcin removed a parent revision: D12882: Implement sending E2EE notification from the client.Aug 21 2024, 10:09 AM
marcin removed a child revision: D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.
marcin added a parent revision: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.
marcin added a child revision: D13123: Update sendDMOperation to send notifs as well.
Harbormaster completed remote builds in B31203: Diff 43557.Aug 21 2024, 10:24 AM
marcin updated this revision to Diff 43675.Aug 27 2024, 5:40 AM

Update queueDBOps to queue notificationsCreationData

Harbormaster completed remote builds in B31283: Diff 43675.Aug 27 2024, 5:57 AM
kamil added inline comments.Aug 27 2024, 8:03 AM
lib/types/db-ops-types.js
15–16 ↗(On Diff #43675)

this is not needed, dmOpID is part of DispatchMetadata

native/redux/redux-setup.js
317–328 ↗(On Diff #43675)

see me comment below how to simplify this

web/redux/redux-setup.js
543–563 ↗(On Diff #43675)

I think this can be simplified?

marcin updated this revision to Diff 43695.Aug 27 2024, 8:36 AM

Address review

Harbormaster completed remote builds in B31294: Diff 43695.Aug 27 2024, 8:58 AM
kamil accepted this revision.Aug 27 2024, 10:35 AM
This revision is now accepted and ready to land.Aug 27 2024, 10:35 AM
marcin updated this revision to Diff 43707.Aug 27 2024, 10:54 AM

Rebase before landing

Harbormaster completed remote builds in B31306: Diff 43707.Aug 27 2024, 11:23 AM
Closed by commit rCOMMa1413b25eba8: Update db ops reducer to process notiications creation data (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyAug 27 2024, 11:30 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMa1413b25eba8: Update db ops reducer to process notiications creation data.

Revision Contents
Changeset List

PathSize
lib/
reducers/
2 lines
shared/
dm-ops/
2 lines
tunnelbroker/
10 lines
types/
2 lines

Diff 43222

View Options

lib/reducers/db-ops-reducer.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/dm-op-spec.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

lib/tunnelbroker/peer-to-peer-context.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines