Paths

Table of Contentst

[SQLite] recreate table for Inbound P2P messages
ClosedPublic
Actions

Authored by kamil on Aug 12 2024, 6:43 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMMd3139aed0de5: [SQLite] recreate table for Inbound P2P messages

Summary

ENG-6982.

Rename the table to reflect to existing naming.
Add a column with userID; it turns out it is needed for some messages.

I am dropping the table because right now it should be empty for users.

Depends on D13046

Test Plan

Migration succeeded.
Creating DB from scratch works.
Tests

Diff Detail

Repository

rCOMM Comm

Branch

resending-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 12 2024, 6:43 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 12 2024, 6:43 AM

kamil added a child revision: D13049: [lib] process Inbound P2P messages on app start.Aug 12 2024, 6:49 AM

Harbormaster completed remote builds in B31041: Diff 43305.Aug 12 2024, 8:11 AM

kamil published this revision for review.Aug 13 2024, 3:09 AM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.Aug 14 2024, 6:46 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
804–805

tomek accepted this revision.Aug 19 2024, 5:51 AM

This revision is now accepted and ready to land.Aug 19 2024, 5:51 AM

remove code

Harbormaster completed remote builds in B31169: Diff 43499.Aug 20 2024, 4:38 AM

Closed by commit rCOMMd3139aed0de5: [SQLite] recreate table for Inbound P2P messages (authored by kamil). · Explain WhyAug 21 2024, 2:57 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd3139aed0de5: [SQLite] recreate table for Inbound P2P messages.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

use-peer-to-peer-message-handler.js

1 line

types/

crypto-types.js

1 line

sqlite-types.js

1 line

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

40 lines

entities/

InboundP2PMessage.h

5 lines

NativeModules/

CommCoreModule.h

1 line

CommCoreModule.cpp

7 lines

_generated/

commJSI-generated.cpp

commJSI.h

schema/

CommCoreModuleSchema.js

2 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

1 line

shared-worker/

_generated/

comm_query_executor.wasm

queries/

inbound-p2p-message-queries.test.js

3 lines

worker/

worker-crypto.js

2 lines

Diff 43305

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

View Options

lib/types/crypto-types.js

View Options

lib/types/sqlite-types.js

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/InboundP2PMessage.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/schema/CommCoreModuleSchema.js

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/inbound-p2p-message-queries.test.js

View Options

web/shared-worker/worker/worker-crypto.js

[SQLite] recreate table for Inbound P2P messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43305

lib/tunnelbroker/use-peer-to-peer-message-handler.js

lib/types/crypto-types.js

lib/types/sqlite-types.js

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/InboundP2PMessage.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/schema/CommCoreModuleSchema.js

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/inbound-p2p-message-queries.test.js

web/shared-worker/worker/worker-crypto.js

[SQLite] recreate table for Inbound P2P messages
ClosedPublic
Actions

Revision Contents
Changeset List