Page MenuHomePhabricator
Differential D13047

[SQLite] recreate table for Inbound P2P messages
ClosedPublic
Actions

Authored by kamil on Aug 12 2024, 6:43 AM.
Tags
None
Referenced Files
F2755088: D13047.diff
Wed, Sep 18, 9:30 PM
Unknown Object (File)
Sun, Sep 15, 9:07 AM
Unknown Object (File)
Sun, Sep 15, 9:06 AM
Unknown Object (File)
Thu, Sep 5, 1:55 PM
Unknown Object (File)
Tue, Sep 3, 6:35 AM
Unknown Object (File)
Tue, Sep 3, 6:35 AM
Unknown Object (File)
Mon, Sep 2, 12:25 AM
Unknown Object (File)
Sat, Aug 31, 3:05 AM
View All 18 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMMd3139aed0de5: [SQLite] recreate table for Inbound P2P messages
Summary

ENG-6982.

  1. Rename the table to reflect to existing naming.
  2. Add a column with userID; it turns out it is needed for some messages.

I am dropping the table because right now it should be empty for users.

Depends on D13046

Test Plan
  1. Migration succeeded.
  2. Creating DB from scratch works.
  3. Tests

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 12 2024, 6:43 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 12 2024, 6:43 AM
kamil added a child revision: D13049: [lib] process Inbound P2P messages on app start.Aug 12 2024, 6:49 AM
Harbormaster completed remote builds in B31041: Diff 43305.Aug 12 2024, 8:11 AM
kamil published this revision for review.Aug 13 2024, 3:09 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.Aug 14 2024, 6:46 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
804–805 ↗(On Diff #43305)
tomek accepted this revision.Aug 19 2024, 5:51 AM
This revision is now accepted and ready to land.Aug 19 2024, 5:51 AM
kamil updated this revision to Diff 43499.Tue, Aug 20, 4:17 AM

remove code

Harbormaster completed remote builds in B31169: Diff 43499.Tue, Aug 20, 4:38 AM
Closed by commit rCOMMd3139aed0de5: [SQLite] recreate table for Inbound P2P messages (authored by kamil). · Explain WhyWed, Aug 21, 2:57 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd3139aed0de5: [SQLite] recreate table for Inbound P2P messages.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
1 line
types/
1 line
1 line
native/
cpp/
CommonCpp/
DatabaseManagers/
37 lines
entities/
5 lines
NativeModules/
1 line
7 lines
_generated/
schema/
2 lines
web/
cpp/
1 line
shared-worker/
_generated/
queries/
3 lines
worker/
2 lines

Diff 43499

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...
View Options

lib/types/crypto-types.js

Loading...
View Options

lib/types/sqlite-types.js

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/InboundP2PMessage.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/inbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...