Page MenuHomePhabricator

[lib] resend messages after session creation request
ClosedPublic

Authored by kamil on Aug 13 2024, 4:49 AM.
Tags
None
Referenced Files
F3348959: D13056.diff
Fri, Nov 22, 4:33 PM
Unknown Object (File)
Wed, Nov 20, 3:09 AM
Unknown Object (File)
Wed, Nov 20, 2:44 AM
Unknown Object (File)
Sat, Nov 9, 10:19 AM
Unknown Object (File)
Fri, Nov 8, 1:55 PM
Unknown Object (File)
Sun, Nov 3, 5:47 AM
Unknown Object (File)
Oct 22 2024, 1:16 PM
Unknown Object (File)
Oct 22 2024, 9:15 AM
Subscribers

Details

Summary

ENG-6982.

The code here is executed in two cases:

  1. First session request - this call is a no-op because we haven't sent any Outbound messages yet.
  2. Session request with higher session - this means that the device that sent the request has a malformed session and we need to re-encrypt and resend all not confirmed messages.

Depends on D13032

Test Plan
  1. Create a session between devices A and B
  2. On B comment out sending confirmation.
  3. Send some messages from A to B
  4. From B to A send session request with higher session counter.
  5. Test that all messages are sent again and decrypted successfully

Diff Detail

Repository
rCOMM Comm
Branch
resending-3
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 13 2024, 4:49 AM
kamil edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Aug 19 2024, 5:55 AM