Page MenuHomePhabricator

[lib] resend messages after race condition
ClosedPublic

Authored by kamil on Aug 8 2024, 5:27 AM.
Tags
None
Referenced Files
F3197886: D13032.id43260.diff
Sat, Nov 9, 10:05 AM
Unknown Object (File)
Fri, Oct 18, 5:17 PM
Unknown Object (File)
Fri, Oct 18, 6:59 AM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Oct 8 2024, 2:44 AM
Subscribers

Details

Summary
Test Plan
  1. Create a session between devices A and B
  2. On B comment out sending confirmation.
  3. Send some messages from A to B
  4. From B to A send a session request with the same session counter to trigger resolving the race condition
  5. Test that all messages are sent again and decrypted successfully

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 8 2024, 5:48 AM
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
lib/tunnelbroker/use-resend-peer-to-peer-messages.js
16 ↗(On Diff #43260)
This revision is now accepted and ready to land.Aug 12 2024, 1:21 AM
This revision was landed with ongoing or failed builds.Aug 21 2024, 2:57 AM
This revision was automatically updated to reflect the committed changes.