Page MenuHomePhabricator

[lib] reset session and resend message when device is unable to decrypt messages
ClosedPublic

Authored by kamil on Aug 12 2024, 2:49 AM.
Tags
None
Referenced Files
F3197799: D13046.id43304.diff
Sat, Nov 9, 9:52 AM
F3197798: D13046.id43498.diff
Sat, Nov 9, 9:52 AM
Unknown Object (File)
Thu, Nov 7, 5:13 AM
Unknown Object (File)
Tue, Oct 22, 1:16 PM
Unknown Object (File)
Tue, Oct 22, 10:23 AM
Unknown Object (File)
Tue, Oct 22, 10:23 AM
Unknown Object (File)
Tue, Oct 22, 9:15 AM
Unknown Object (File)
Tue, Oct 22, 8:32 AM
Subscribers

Details

Summary

ENG-6982.

We want to reset session when there was an error while decrypting.

Depends on D13033

Test Plan
  1. Create a session between devices A and B
  2. On B comment out sending confirmation.
  3. Send some messages from A to B
  4. On B simulate Olm error.
  5. Test that all messages are sent again and decrypted successfully.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 12 2024, 3:04 AM
kamil added inline comments.
lib/utils/olm-utils.js
126–129 ↗(On Diff #43304)

We no longer track order and not using sequential decrypt

tomek added inline comments.
lib/utils/olm-utils.js
123 ↗(On Diff #43304)
This revision is now accepted and ready to land.Aug 19 2024, 5:46 AM