Page MenuHomePhabricator
Differential D13141

[native] Expose messages fetching function through JSI
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 10:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 7:42 AM
Unknown Object (File)
Sat, Mar 8, 5:11 PM
Unknown Object (File)
Sat, Mar 8, 5:11 PM
Unknown Object (File)
Sat, Mar 8, 5:11 PM
Unknown Object (File)
Sat, Mar 8, 5:10 PM
Unknown Object (File)
Sat, Mar 8, 5:10 PM
Unknown Object (File)
Feb 17 2025, 7:38 AM
Unknown Object (File)
Feb 10 2025, 5:36 PM
View All 74 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM3a23e30a4fc0: [native] Expose messages fetching function through JSI
Summary

Expose the function through JSI so that it can be used on native clients.

https://linear.app/comm/issue/ENG-8701/create-c-functions-that-fetch-a-subset-of-messages

Depends on D13140

Test Plan

Tested this later in the stack by creating a thick thread on native, with 100 messages, closing and reopening the app, and scrolling up - verified that all the messages were eventually shown.

Diff Detail

Repository
rCOMM Comm
Branch
messages-pruning
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Aug 22 2024, 10:40 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 10:40 AM
tomek added a child revision: D13142: [web] Expose messages fetching function through the worker and sqlite-api.Aug 22 2024, 10:48 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 22 2024, 11:04 AM
Harbormaster failed remote builds in B31221: Diff 43592!
tomek updated this revision to Diff 43598.Aug 23 2024, 3:54 AM

Fix compilation error

Harbormaster completed remote builds in B31225: Diff 43598.Aug 23 2024, 4:11 AM
tomek requested review of this revision.Aug 23 2024, 4:11 AM
kamil accepted this revision.Aug 26 2024, 2:49 AM

Please update the test plan, accepting it because it looks like it was tested later in the stack

This revision is now accepted and ready to land.Aug 26 2024, 2:49 AM
tomek edited the test plan for this revision. (Show Details)Aug 27 2024, 4:48 AM
Closed by commit rCOMM3a23e30a4fc0: [native] Expose messages fetching function through JSI (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM3a23e30a4fc0: [native] Expose messages fetching function through JSI.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
5 lines
42 lines
_generated/
schema/
5 lines

Diff 43592

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

native/cpp/CommonCpp/_generated/commJSI.h

// @flow // @flow
import type { import type {
FetchInviteLinksResponse, FetchInviteLinksResponse,
InviteLinkVerificationRequest, InviteLinkVerificationRequest,
InviteLinkVerificationResponse, InviteLinkVerificationResponse,
CreateOrUpdatePublicLinkRequest, CreateOrUpdatePublicLinkRequest,
InviteLink, InviteLink,
DisableInviteLinkRequest,
DisableInviteLinkPayload,
} from '../types/link-types.js'; } from '../types/link-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
const verifyInviteLinkActionTypes = Object.freeze({ const verifyInviteLinkActionTypes = Object.freeze({
started: 'VERIFY_INVITE_LINK_STARTED', started: 'VERIFY_INVITE_LINK_STARTED',
success: 'VERIFY_INVITE_LINK_SUCCESS', success: 'VERIFY_INVITE_LINK_SUCCESS',
failed: 'VERIFY_INVITE_LINK_FAILED', failed: 'VERIFY_INVITE_LINK_FAILED',
}); });
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return {
role: response.role, role: response.role,
communityID: response.communityID, communityID: response.communityID,
expirationTime: response.expirationTime, expirationTime: response.expirationTime,
limitOfUses: response.limitOfUses, limitOfUses: response.limitOfUses,
numberOfUses: response.numberOfUses, numberOfUses: response.numberOfUses,
}; };
}; };
const disableInviteLinkLinkActionTypes = Object.freeze({
started: 'DISABLE_INVITE_LINK_STARTED',
success: 'DISABLE_INVITE_LINK_SUCCESS',
failed: 'DISABLE_INVITE_LINK_FAILED',
});
const disableInviteLink =
(
callServerEndpoint: CallServerEndpoint,
): ((
request: DisableInviteLinkRequest,
) => Promise<DisableInviteLinkPayload>) =>
async request => {
await callServerEndpoint('disable_invite_link', request);
return {
name: request.name,
communityID: request.communityID,
};
};
export { export {
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
verifyInviteLink, verifyInviteLink,
fetchPrimaryInviteLinkActionTypes, fetchPrimaryInviteLinkActionTypes,
fetchPrimaryInviteLinks, fetchPrimaryInviteLinks,
createOrUpdatePublicLinkActionTypes, createOrUpdatePublicLinkActionTypes,
createOrUpdatePublicLink, createOrUpdatePublicLink,
disableInviteLinkLinkActionTypes,
disableInviteLink,
}; };
View Options

native/schema/CommCoreModuleSchema.js

Loading...