Paths

Table of Contentst

Differential D13166

Enrich CommMMKV api with operations that manipulate string set
ClosedPublic
Actions

Authored by marcin on Aug 26 2024, 5:03 AM.

Tags

None

Referenced Files

	F3002454: D13166.id43725.diff
	Fri, Oct 18, 7:54 AM

	F3002297: D13166.id43871.diff
	Fri, Oct 18, 7:19 AM

	Unknown Object (File)
	Wed, Oct 2, 3:30 AM

	Unknown Object (File)
	Fri, Sep 27, 3:38 AM

	Unknown Object (File)
	Thu, Sep 26, 9:25 AM

	Unknown Object (File)
	Wed, Sep 25, 3:08 PM

	Unknown Object (File)
	Tue, Sep 24, 10:03 PM

	Unknown Object (File)
	Mon, Sep 23, 6:24 AM

View All 47 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMae1816b41329: Enrich CommMMKV api with operations that manipulate string set

Summary

This differential enriches CommMMKV api with new methods that add, remove and get size of set of strings stored in MMKV under some key. The purpose here is to keep list of unread thick threads in MMKV and updated it and use it from notifs code to handle the bacge icon update.

Test Plan

Tested in next differential

Diff Detail

Repository

Branch

marcin/eng-8284-new-tmp

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 26 2024, 5:03 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 26 2024, 5:03 AM

marcin added a parent revision: D13165: Return single curve25519 string from NotificationsInboundKeysProvider.Aug 26 2024, 5:03 AM

Harbormaster completed remote builds in B31255: Diff 43630.Aug 26 2024, 5:19 AM

marcin requested review of this revision.Aug 26 2024, 5:19 AM

marcin added a child revision: D13167: Implement thick thread badge updates and rescinds handling in native notifs code.Aug 26 2024, 5:28 AM

Refactor getStringSetSize to getStringSet

Harbormaster completed remote builds in B31317: Diff 43725.Aug 28 2024, 3:29 AM

tomek accepted this revision.Aug 30 2024, 3:03 AM

tomek added inline comments.

native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java
181 ↗	(On Diff #43725)	We can simplify it

This revision is now accepted and ready to land.Aug 30 2024, 3:03 AM

Rebase before landing

Harbormaster completed remote builds in B31416: Diff 43862.Sep 3 2024, 7:49 AM

Closed by commit rCOMMae1816b41329: Enrich CommMMKV api with operations that manipulate string set (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMae1816b41329: Enrich CommMMKV api with operations that manipulate string set.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

cpp/

46 lines

main/

java/

app/

comm/

android/

fbjni/

45 lines

cpp/

CommonCpp/

Tools/

5 lines

ios/

Comm/

57 lines

Diff 43630

native/android/app/src/cpp/CommMMKV.cpp

Loading...

native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java

Loading...

native/cpp/CommonCpp/Tools/CommMMKV.h

Loading...

native/ios/Comm/CommMMKV.mm

Loading...