Page MenuHomePhabricator
Differential D13138

[web] Extract a function that creates web messages
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 9:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 5:12 PM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:44 PM
Unknown Object (File)
Tue, Oct 22, 8:33 AM
Unknown Object (File)
Oct 1 2024, 3:48 AM
Unknown Object (File)
Oct 1 2024, 1:23 AM
Unknown Object (File)
Sep 29 2024, 3:35 PM
Unknown Object (File)
Sep 29 2024, 1:31 PM
View All 32 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM695c02284c8f: [web] Extract a function that creates web messages
Summary

This logic was repeated, and I need to use it in the next diff.

Depends on D13137

Test Plan

Tests.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Aug 22 2024, 9:17 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 9:17 AM
tomek updated this revision to Diff 43582.Aug 22 2024, 9:27 AM

Rename

Harbormaster completed remote builds in B31215: Diff 43573.Aug 22 2024, 9:34 AM
tomek updated this revision to Diff 43584.Aug 22 2024, 9:37 AM

Rebase

Harbormaster failed remote builds in B31216: Diff 43582!Aug 22 2024, 9:40 AM
Harbormaster completed remote builds in B31218: Diff 43584.Aug 22 2024, 9:54 AM
tomek requested review of this revision.Aug 22 2024, 9:54 AM
tomek added a child revision: D13140: [web] Create a function that fetches messages in batches.Aug 22 2024, 10:19 AM
tomek updated this revision to Diff 43621.Aug 23 2024, 9:23 AM

Rebase

Harbormaster completed remote builds in B31248: Diff 43621.Aug 23 2024, 9:39 AM
kamil accepted this revision.Aug 26 2024, 2:14 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
207–208 ↗(On Diff #43621)

I would move this to line 45 to make this private

This revision is now accepted and ready to land.Aug 26 2024, 2:14 AM
tomek updated this revision to Diff 43668.Aug 27 2024, 3:27 AM
tomek marked an inline comment as done.

Make the method private

Harbormaster completed remote builds in B31276: Diff 43668.Aug 27 2024, 3:49 AM
tomek updated this revision to Diff 43669.Aug 27 2024, 4:36 AM

Remove the method from DatabaseQueryExecutor

Harbormaster completed remote builds in B31277: Diff 43669.Aug 27 2024, 4:53 AM
Closed by commit rCOMM695c02284c8f: [web] Extract a function that creates web messages (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM695c02284c8f: [web] Extract a function that creates web messages.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
32 lines
web/
shared-worker/
_generated/

Diff 43669

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...