Page MenuHomePhabricator
Differential D13193

[lib] make it possible to send DM ops to all thread members
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 6:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 2:09 AM
Unknown Object (File)
Fri, Mar 7, 1:43 AM
Unknown Object (File)
Fri, Mar 7, 12:41 AM
Unknown Object (File)
Thu, Mar 6, 1:34 PM
Unknown Object (File)
Wed, Mar 5, 2:59 PM
Unknown Object (File)
Wed, Mar 5, 8:12 AM
Unknown Object (File)
Tue, Mar 4, 10:34 PM
Unknown Object (File)
Tue, Mar 4, 10:34 PM
View All 93 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM162fe1df034a: [lib] make it possible to send DM ops to all thread members
Summary

This is a fix for https://phab.comm.dev/D13187#inline-76074.

We going to specify threadID or parenThreadID depending on thread type.

Test Plan

Tested later in the stack - making sure ops are delivered to all members.

Diff Detail

Repository
rCOMM Comm
Branch
logic-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 6:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 6:23 AM
kamil published this revision for review.Aug 28 2024, 6:24 AM
kamil added a child revision: D13186: [lib][native] update `useEditMessage` return type.
kamil retitled this revision from [lib] make it possible to send DM ops to all thread member to [lib] make it possible to send DM ops to all thread members.
kamil updated this revision to Diff 43742.Aug 28 2024, 6:30 AM

rebase

kamil updated this revision to Diff 43743.Aug 28 2024, 6:35 AM

rebase v2

Harbormaster completed remote builds in B31330: Diff 43738.Aug 28 2024, 6:40 AM
Harbormaster completed remote builds in B31332: Diff 43742.Aug 28 2024, 6:51 AM
Harbormaster completed remote builds in B31333: Diff 43743.
kamil added a child revision: D13192: [lib] implement changing DM threads settings.Aug 28 2024, 7:34 AM
kamil added a child revision: D13184: [native] implement leaving DM thread.Aug 28 2024, 7:49 AM
tomek accepted this revision.Aug 28 2024, 7:56 AM
This revision is now accepted and ready to land.Aug 28 2024, 7:56 AM
kamil added a child revision: D13173: [web][native] update `useSendReaction` to `ThreadInfo` instead of `threadID` only.Aug 28 2024, 8:06 AM
Closed by commit rCOMM162fe1df034a: [lib] make it possible to send DM ops to all thread members (authored by kamil). · Explain WhyAug 28 2024, 8:33 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM162fe1df034a: [lib] make it possible to send DM ops to all thread members.
kamil added a child revision: D13197: [lib] implement adding thread members for DMs.Aug 28 2024, 8:37 AM
kamil added a child revision: D13201: [web][native] update text messages recipients.Aug 28 2024, 8:53 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
117 lines
1 line

Diff 43742

View Options

lib/shared/dm-ops/dm-op-utils.js

  • This file was added.
// @flow
import * as React from 'react';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { homeChatThreadListOptions } from '../chat/chat-options.js';
import {
type NUXTipsOverlayProps,
createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js';
const homeTabTipText =
'Your home screen only shows the chats you’ve joined. ' +
'When you join a community on Comm, you only join the root of the tree.';
const HomeTabTip: React.ComponentType<NUXTipsOverlayProps<'HomeTabTip'>> =
createNUXTipsOverlay(
createChatTabBarButton<'HomeTabTip'>(homeChatThreadListOptions),
homeTabTipText,
);
export default HomeTabTip;
View Options

lib/shared/dm-ops/process-dm-ops.js

  • This file was added.
// @flow
import * as React from 'react';
import { createChatTabBarButton } from './chat-tab-bar-button.react.js';
import { homeChatThreadListOptions } from '../chat/chat-options.js';
import {
type NUXTipsOverlayProps,
createNUXTipsOverlay,
} from '../tooltip/nux-tips-overlay.react.js';
const homeTabTipText =
'Your home screen only shows the chats you’ve joined. ' +
'When you join a community on Comm, you only join the root of the tree.';
const HomeTabTip: React.ComponentType<NUXTipsOverlayProps<'HomeTabTip'>> =
createNUXTipsOverlay(
createChatTabBarButton<'HomeTabTip'>(homeChatThreadListOptions),
homeTabTipText,
);
export default HomeTabTip;