Differential D13199

[web] implement adding thread members in `AddUsersModal`
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 8:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 2, 12:01 PM

	Unknown Object (File)
	Tue, Mar 11, 12:00 PM

	Unknown Object (File)
	Mar 5 2025, 12:02 AM

	Unknown Object (File)
	Mar 4 2025, 10:35 PM

	Unknown Object (File)
	Mar 4 2025, 10:35 PM

	Unknown Object (File)
	Mar 4 2025, 10:34 PM

	Unknown Object (File)
	Mar 4 2025, 10:34 PM

	Unknown Object (File)
	Mar 4 2025, 5:18 PM

View All 64 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM1c3319f684b0: [web] implement adding thread members in `AddUsersModal`

Summary

Updating component logic

Depends on D13198

Test Plan

Created thread with users A and B.
On A add user C.
Make sure C is added on both A and B, and C has now able to see the thread.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 28 2024, 8:48 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 8:48 AM

kamil added a child revision: D13200: [web][native] add test button to create DM thread.Aug 28 2024, 8:49 AM

Harbormaster failed remote builds in B31350: Diff 43768!Aug 28 2024, 9:06 AM

kamil published this revision for review.Aug 28 2024, 9:17 AM

tomek accepted this revision.Aug 28 2024, 9:30 AM

This revision is now accepted and ready to land.Aug 28 2024, 9:30 AM

Harbormaster completed remote builds in B31350: Diff 43768.Aug 28 2024, 9:37 AM

Closed by commit rCOMM1c3319f684b0: [web] implement adding thread members in `AddUsersModal` (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1c3319f684b0: [web] implement adding thread members in `AddUsersModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

add-members-modal.react.js

28 lines

Diff 43787

web/modals/threads/members/add-members-modal.react.js

This file was added.

				# VPC
				resource "aws_vpc" "default" {
				cidr_block = "172.31.0.0/16"
				enable_dns_support = true
				enable_dns_hostnames = true
				}

				# Public Subnets
				resource "aws_subnet" "public_a" {
				vpc_id = aws_vpc.default.id
				cidr_block = "172.31.0.0/20"
				availability_zone = "us-east-2a"
				map_public_ip_on_launch = true
				}

				resource "aws_subnet" "public_b" {
				vpc_id = aws_vpc.default.id
				cidr_block = "172.31.16.0/20"
				availability_zone = "us-east-2b"
				map_public_ip_on_launch = true
				}

				# Internet Gateway
				resource "aws_internet_gateway" "default" {
				vpc_id = aws_vpc.default.id
				}

				# Route Table for Internet Gateway
				resource "aws_route_table" "public_igw_route_table" {
				vpc_id = aws_vpc.default.id

				route {
				cidr_block = "0.0.0.0/0"
				gateway_id = aws_internet_gateway.default.id
				}
				}

				resource "aws_route_table_association" "public_a_igw_route_association" {
				subnet_id = aws_subnet.public_a.id
				route_table_id = aws_route_table.public_igw_route_table.id
				}

				resource "aws_route_table_association" "public_b_igw_route_association" {
				subnet_id = aws_subnet.public_b.id
				route_table_id = aws_route_table.public_igw_route_table.id
				}