[web][native] update `useSendReaction` to send DMs reactions
ClosedPublic
Actions

Authored by kamil on Tue, Aug 27, 4:48 AM.

Details

Reviewers

tomek
inka

Commits

rCOMMe2aaf9df7997: [web][native] update `useSendReaction` to send DMs reactions

Summary

ENG-8975

We could consider moving this to shared code in lib but at this point, I don't think it worth adding another abstraction layer. For other ops, logic could be specific and different. After implementing other DM ops we can see what can be extracted.

Depends on D13173

Test Plan

Create DM thread.
Send reaction.
See if this is visible on all peers.
Turn off internet connection and send reaction (should not fail).
Turn on internet connection, reaction visible is for on all peers.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Aug 27, 4:48 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Aug 27, 4:48 AM

Harbormaster completed remote builds in B31280: Diff 43672.Tue, Aug 27, 5:05 AM

kamil published this revision for review.Tue, Aug 27, 5:07 AM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Wed, Aug 28, 3:48 AM

This revision is now accepted and ready to land.Wed, Aug 28, 3:48 AM

rebase

Harbormaster completed remote builds in B31345: Diff 43756.Wed, Aug 28, 8:23 AM

Closed by commit rCOMMe2aaf9df7997: [web][native] update `useSendReaction` to send DMs reactions (authored by kamil). · Explain WhyWed, Aug 28, 8:33 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMe2aaf9df7997: [web][native] update `useSendReaction` to send DMs reactions.

Revision Contents
Changeset List

Path

Size

native/

chat/

reaction-message-utils.js

42 lines

web/

chat/

reaction-message-utils.js

42 lines

Diff 43764

View Options

native/chat/reaction-message-utils.js