Page MenuHomePhabricator

[lib] add editing DM messages
ClosedPublic

Authored by kamil on Aug 28 2024, 2:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 10:04 PM
Unknown Object (File)
Wed, Nov 6, 10:04 PM
Unknown Object (File)
Wed, Nov 6, 10:04 PM
Unknown Object (File)
Wed, Nov 6, 10:04 PM
Unknown Object (File)
Wed, Nov 6, 9:41 PM
Unknown Object (File)
Mon, Nov 4, 1:36 PM
Unknown Object (File)
Oct 13 2024, 7:31 PM
Unknown Object (File)
Oct 13 2024, 8:51 AM
Subscribers

Details

Summary

ENG-8976;

Update components logic.

Depends on D13186

Test Plan

Test editing in DM thread on both web and native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 28 2024, 3:59 AM
tomek requested changes to this revision.Aug 28 2024, 5:39 AM
tomek added inline comments.
lib/shared/edit-messages-utils.js
58 ↗(On Diff #43723)

Thinking about it more, I'm not sure if this is correct (the same concern applies to other diffs). If someone is a member of a thread and isn't a member of its sidebar, can they see a sidebar and the messages it contains? I think that yes, which means that we should send it to all the members - for a thick thread, or all the members of the parent thread - for sidebars.

This revision now requires changes to proceed.Aug 28 2024, 5:39 AM
This revision is now accepted and ready to land.Aug 28 2024, 7:56 AM