Differential D13187

[lib] add editing DM messages
ClosedPublic
Actions

Authored by kamil on Wed, Aug 28, 2:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 16, 8:06 PM

	Unknown Object (File)
	Sat, Sep 14, 12:04 PM

	Unknown Object (File)
	Wed, Sep 11, 5:54 PM

	Unknown Object (File)
	Mon, Sep 9, 9:57 AM

	Unknown Object (File)
	Mon, Sep 9, 9:50 AM

	Unknown Object (File)
	Sun, Sep 8, 9:43 PM

	Unknown Object (File)
	Sat, Sep 7, 2:19 PM

	Unknown Object (File)
	Fri, Sep 6, 11:53 PM

View All 26 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMMa310cb1fbbbc: [lib] add editing DM messages

Summary

Update components logic.

Depends on D13186

Test Plan

Test editing in DM thread on both web and native.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Wed, Aug 28, 2:56 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Aug 28, 2:56 AM

Harbormaster completed remote builds in B31315: Diff 43723.Wed, Aug 28, 3:18 AM

kamil published this revision for review.Wed, Aug 28, 3:59 AM

tomek requested changes to this revision.Wed, Aug 28, 5:39 AM

tomek added inline comments.

lib/shared/edit-messages-utils.js
58 ↗	(On Diff #43723)	Thinking about it more, I'm not sure if this is correct (the same concern applies to other diffs). If someone is a member of a thread and isn't a member of its sidebar, can they see a sidebar and the messages it contains? I think that yes, which means that we should send it to all the members - for a thick thread, or all the members of the parent thread - for sidebars.

This revision now requires changes to proceed.Wed, Aug 28, 5:39 AM

kamil mentioned this in D13193: [lib] make it possible to send DM ops to all thread members.Wed, Aug 28, 6:23 AM

address review

Harbormaster completed remote builds in B31337: Diff 43747.Wed, Aug 28, 7:13 AM

tomek accepted this revision.Wed, Aug 28, 7:56 AM

This revision is now accepted and ready to land.Wed, Aug 28, 7:56 AM

Closed by commit rCOMMa310cb1fbbbc: [lib] add editing DM messages (authored by kamil). · Explain WhyWed, Aug 28, 8:33 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM162fe1df034a: [lib] make it possible to send DM ops to all thread members.

kamil added a commit: rCOMMa310cb1fbbbc: [lib] add editing DM messages.

kamil mentioned this in D13201: [web][native] update text messages recipients.Wed, Aug 28, 8:53 AM

kamil mentioned this in rCOMMaef6d707b904: [web][native] update text messages recipients.Thu, Aug 29, 1:15 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

edit-messages-utils.js

83 lines

native/

chat/

chat-input-bar.react.js

2 lines

web/

chat/

edit-text-message.react.js

2 lines

Diff 43759

lib/shared/edit-messages-utils.js

Loading...

native/chat/chat-input-bar.react.js

Loading...

web/chat/edit-text-message.react.js

Loading...