[lib] add editing DM messages
ClosedPublic
Actions

Authored by kamil on Wed, Aug 28, 2:56 AM.

Details

Reviewers

tomek
inka

Commits

rCOMMa310cb1fbbbc: [lib] add editing DM messages

Summary

Update components logic.

Depends on D13186

Test Plan

Test editing in DM thread on both web and native.

Repository

rCOMM Comm

Branch

logic-3

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

kamil published this revision for review.Wed, Aug 28, 3:59 AM

tomek requested changes to this revision.Wed, Aug 28, 5:39 AM

tomek added inline comments.

lib/shared/edit-messages-utils.js
58	Thinking about it more, I'm not sure if this is correct (the same concern applies to other diffs). If someone is a member of a thread and isn't a member of its sidebar, can they see a sidebar and the messages it contains? I think that yes, which means that we should send it to all the members - for a thick thread, or all the members of the parent thread - for sidebars.

This revision now requires changes to proceed.Wed, Aug 28, 5:39 AM

address review

This revision is now accepted and ready to land.Wed, Aug 28, 7:56 AM

This revision was automatically updated to reflect the committed changes.