Page MenuHomePhabricator

[lib] remove `newMemberIDs` from `DMThreadSettingsChanges`
ClosedPublic

Authored by kamil on Aug 28 2024, 7:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 9:41 PM
Unknown Object (File)
Mon, Oct 28, 8:40 PM
Unknown Object (File)
Mon, Oct 28, 7:44 PM
Unknown Object (File)
Thu, Oct 24, 5:35 AM
Subscribers

Details

Summary

ENG-8979;

For adding new members there is separate spec, ADD_MEMBERS and ADD_VIEWER_TO_THREAD_MEMBERS.

Depends on D13192

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 28 2024, 7:55 AM
tomek added inline comments.
lib/shared/dm-ops/change-thread-settings-spec.js
60 ↗(On Diff #43751)

This function could now be inlined in addMembersSpec.

154 ↗(On Diff #43751)

This can also be inlined.

lib/types/dm-ops.js
31–32 ↗(On Diff #43751)

This can be deleted.

281–299 ↗(On Diff #43751)

We can inline dmChangeThreadSettingsBaseValidatorShape into dmChangeThreadSettingsOperationValidator.

306–316 ↗(On Diff #43751)

We can delete these.

This revision is now accepted and ready to land.Aug 28 2024, 9:19 AM