Paths

Table of Contentst

Differential D13195

[lib] remove `newMemberIDs` from `DMThreadSettingsChanges`
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 2:42 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
inka
marcin

Commits

rCOMM92cd9357bc28: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`

Summary

For adding new members there is separate spec, ADD_MEMBERS and ADD_VIEWER_TO_THREAD_MEMBERS.

Depends on D13192

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 28 2024, 2:42 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 2:42 PM

kamil edited the summary of this revision. (Show Details)Aug 28 2024, 2:43 PM

kamil added a parent revision: D13192: [lib] implement changing DM threads settings.

kamil published this revision for review.Aug 28 2024, 2:55 PM

Harbormaster completed remote builds in B31340: Diff 43751.Aug 28 2024, 2:59 PM

tomek accepted this revision.Aug 28 2024, 4:19 PM

tomek added inline comments.

lib/shared/dm-ops/change-thread-settings-spec.js
60 ↗	(On Diff #43751)	This function could now be inlined in `addMembersSpec`.
154 ↗	(On Diff #43751)	This can also be inlined.
lib/types/dm-ops.js
31–32 ↗	(On Diff #43751)	This can be deleted.
281–299 ↗	(On Diff #43751)	We can inline `dmChangeThreadSettingsBaseValidatorShape` into `dmChangeThreadSettingsOperationValidator`.
306–316 ↗	(On Diff #43751)	We can delete these.

This revision is now accepted and ready to land.Aug 28 2024, 4:19 PM

address review

Harbormaster completed remote builds in B31358: Diff 43778.Aug 29 2024, 7:40 AM

Closed by commit rCOMM92cd9357bc28: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`. · Explain WhyAug 29 2024, 8:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM92cd9357bc28: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`.

Revision Contents
Changeset List

Path

Size

lib/

actions/

thread-actions.js

4 lines

shared/

dm-ops/

add-members-spec.js

121 lines

change-thread-settings-and-add-viewer-spec.js

change-thread-settings-spec.js

172 lines

3 lines

types/

53 lines

Diff 43783

lib/actions/thread-actions.js

Loading...

lib/shared/dm-ops/add-members-spec.js

Loading...

lib/shared/dm-ops/change-thread-settings-and-add-viewer-spec.js

Loading...

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...

lib/shared/dm-ops/dm-op-specs.js

Loading...

lib/types/dm-ops.js

Loading...