Differential D13199

[web] implement adding thread members in `AddUsersModal`
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 8:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 19, 4:22 PM

	Unknown Object (File)
	Sat, Apr 19, 4:12 PM

	Unknown Object (File)
	Sat, Apr 19, 12:04 PM

	Unknown Object (File)
	Fri, Apr 18, 2:09 AM

	Unknown Object (File)
	Sat, Apr 12, 7:04 PM

	Unknown Object (File)
	Wed, Apr 2, 12:01 PM

	Unknown Object (File)
	Mar 11 2025, 12:00 PM

	Unknown Object (File)
	Mar 5 2025, 12:02 AM

View All 69 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM1c3319f684b0: [web] implement adding thread members in `AddUsersModal`

Summary

Updating component logic

Depends on D13198

Test Plan

Created thread with users A and B.
On A add user C.
Make sure C is added on both A and B, and C has now able to see the thread.

Diff Detail

Repository

Branch

logic-5

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 8:48 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 8:48 AM

kamil added a child revision: D13200: [web][native] add test button to create DM thread.Aug 28 2024, 8:49 AM

Harbormaster failed remote builds in B31350: Diff 43768!Aug 28 2024, 9:06 AM

kamil published this revision for review.Aug 28 2024, 9:17 AM

tomek accepted this revision.Aug 28 2024, 9:30 AM

This revision is now accepted and ready to land.Aug 28 2024, 9:30 AM

Harbormaster completed remote builds in B31350: Diff 43768.Aug 28 2024, 9:37 AM

Closed by commit rCOMM1c3319f684b0: [web] implement adding thread members in `AddUsersModal` (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1c3319f684b0: [web] implement adding thread members in `AddUsersModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

add-members-modal.react.js

28 lines

Diff 43768

web/modals/threads/members/add-members-modal.react.js

	// @flow			// @flow

	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
				+dmOpID?: string,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};