Page MenuHomePhabricator
Differential D13226

[identity] Implement RestoreUser RPCs
ClosedPublic
Actions

Authored by bartek on Sep 2 2024, 11:43 PM.
Tags
None
Referenced Files
F3348547: D13226.id43848.diff
Fri, Nov 22, 3:07 PM
Unknown Object (File)
Wed, Nov 20, 11:44 AM
Unknown Object (File)
Sat, Nov 9, 3:18 PM
Unknown Object (File)
Sat, Nov 9, 2:44 PM
Unknown Object (File)
Sat, Nov 9, 7:58 AM
Unknown Object (File)
Oct 22 2024, 6:30 PM
Unknown Object (File)
Oct 22 2024, 6:29 PM
Unknown Object (File)
Oct 22 2024, 1:18 PM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
Commits
rCOMM817c5955a206: [identity] Implement RestoreUser RPCs
Summary

Address ENG-8212.

Implemented RPCs for backup restore. Added this all in one diff because the RPC calls existing code in sequence
and the whole flow is more obvious.

Depends on D13221, D13225

Test Plan

Registered a password and a wallet user. Verified that for both:

  • RPC fails if username/wallet address not found (cannot get user ID)
  • Fails if nonce / SIWE verification fails
  • The RPC verifies the device list (the last test case from D13222 is the only valid one)
  • The RPC updates device list and sets new primary device
  • The RPC performs device key upload
  • The RPC removes all old devices' data, OTKs and access tokens
  • The RPC returns new CSAT
  • For wallet users, social proof is updated in DDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 2 2024, 11:43 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2024, 11:43 PM
bartek added a child revision: D13229: [identity] Ask Tunnelbroker to terminate old device sessions.Sep 2 2024, 11:52 PM
bartek mentioned this in D13232: [native][lib] Add RestoreUser RPCs to Identity client.Sep 3 2024, 12:00 AM
Harbormaster completed remote builds in B31402: Diff 43848.Sep 3 2024, 12:00 AM
bartek published this revision for review.Sep 3 2024, 12:09 AM
bartek added inline comments.
services/identity/src/client_service.rs
1368–1372 ↗(On Diff #43848)

I discovered that this allows us to avoid using .map_err(handle_db_error)?; everywhere. We can simply .await?;.
If you think this is okay, I can put up a diff which replaces all map_err with this

varun accepted this revision.Sep 4 2024, 11:26 PM
varun added inline comments.
services/identity/src/client_service.rs
1368–1372 ↗(On Diff #43848)

oh awesome, yeah that would be great, thanks

This revision is now accepted and ready to land.Sep 4 2024, 11:26 PM
bartek updated this revision to Diff 43975.Sep 9 2024, 6:05 AM

Rebase on feedback: Merge RPCs into one

bartek added a child revision: D13269: [identity] Replace handle_db_error mapping with question mark.Sep 9 2024, 6:06 AM
Harbormaster completed remote builds in B31489: Diff 43975.Sep 9 2024, 6:22 AM
Closed by commit rCOMM817c5955a206: [identity] Implement RestoreUser RPCs (authored by bartek). · Explain WhySep 13 2024, 3:36 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM817c5955a206: [identity] Implement RestoreUser RPCs.
bartek mentioned this in rCOMM7a52ffcf5311: [native][lib] Add RestoreUser RPCs to Identity client.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
172 lines
1 line
database/
4 lines

Diff 43975

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...