Page MenuHomePhabricator
Differential D13283

[lib] Fix resetting thick thread avatars
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 1:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 1:46 PM
Unknown Object (File)
Tue, Apr 1, 1:45 PM
Unknown Object (File)
Tue, Apr 1, 1:27 PM
Unknown Object (File)
Tue, Apr 1, 7:43 AM
Unknown Object (File)
Mon, Mar 31, 8:07 AM
Unknown Object (File)
Tue, Mar 25, 8:18 PM
Unknown Object (File)
Mar 7 2025, 1:38 AM
Unknown Object (File)
Mar 1 2025, 10:58 AM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
tomek
inka
Commits
rCOMMe0b1a8417c08: [lib] Fix resetting thick thread avatars
Summary

Addresses ENG-9208.
The case when avatar was reset for DM thread, wasn't supported in the thread-actions.js and later in the DM op.

Investigated how this is handled on keyserver and added appropriate logic here.

Test Plan

Confirmed that clicking the "Reset avatar" button in thread settings menu actually resets the avatar.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 11 2024, 1:29 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 11 2024, 1:29 AM
bartek added a child revision: D13285: [lib] Support image avatars in DM thread-action.Sep 11 2024, 1:36 AM
Harbormaster completed remote builds in B31521: Diff 44025.Sep 11 2024, 1:46 AM
bartek published this revision for review.Sep 11 2024, 1:55 AM
bartek added reviewers: tomek, inka.
bartek added inline comments.
lib/shared/dm-ops/change-thread-settings-spec.js
69

Empty string is the value that causes avatar to reset - keyserver does it the same way here

lib/types/dm-ops.js
291

Wondering if instead of null, it's better to use UpdateUserAvatarRemoveRequest here. This would make the above ternary much cleaner

tomek accepted this revision.Sep 11 2024, 2:07 AM
tomek added inline comments.
lib/shared/dm-ops/change-thread-settings-spec.js
67–72

Can we simplify this expression and avoid nested ternaries?

lib/types/dm-ops.js
291

That makes sense but maybe we should use UpdateUserAvatarRequest then

This revision is now accepted and ready to land.Sep 11 2024, 2:07 AM
bartek added inline comments.Sep 11 2024, 2:16 AM
lib/shared/dm-ops/change-thread-settings-spec.js
67–72

Yeah sure

lib/types/dm-ops.js
291

I guess it's not a good idea because we still need to convert UpdateUserAvatarRequest -> ClientAvatar at some point. Currently, we do it earlier, in thread-actions.js

bartek added inline comments.Sep 13 2024, 4:10 AM
lib/types/dm-ops.js
291

After refactoring ternaries I think null is clear enough, also left a comment

bartek updated this revision to Diff 44142.Sep 13 2024, 4:10 AM

Replace ternaries to make conditions more readable

Harbormaster completed remote builds in B31597: Diff 44142.Sep 13 2024, 4:30 AM
Closed by commit rCOMMe0b1a8417c08: [lib] Fix resetting thick thread avatars (authored by bartek). · Explain WhySep 13 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe0b1a8417c08: [lib] Fix resetting thick thread avatars.

Revision Contents
Changeset List

PathSize
lib/
actions/
5 lines
shared/
dm-ops/
11 lines
types/
2 lines

Diff 44025

View Options

lib/actions/thread-actions.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1
View Options

lib/types/dm-ops.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1