Page MenuHomePhabricator
Differential D13231

[native] Add RestoreUser RPCs to JSI
ClosedPublic
Actions

Authored by bartek on Sep 2 2024, 11:54 PM.
Tags
None
Referenced Files
F3385567: D13231.diff
Fri, Nov 29, 1:01 AM
Unknown Object (File)
Wed, Nov 27, 7:14 AM
Unknown Object (File)
Wed, Nov 27, 2:55 AM
Unknown Object (File)
Mon, Nov 25, 9:32 PM
Unknown Object (File)
Mon, Nov 25, 2:30 PM
Unknown Object (File)
Mon, Nov 25, 2:03 PM
Unknown Object (File)
Mon, Nov 25, 1:43 PM
Unknown Object (File)
Mon, Nov 25, 12:11 AM
View All 69 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
Commits
rCOMMe83c2a1be04e: [native] Add RestoreUser RPCs to JSI
Summary

Exposed restore user RPCs via JSI

Depends on D13230

Test Plan

Native compiles. Usage tested in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Sep 2 2024, 11:54 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2024, 11:54 PM
Harbormaster completed remote builds in B31407: Diff 43853.Sep 3 2024, 12:15 AM
bartek published this revision for review.Sep 3 2024, 12:16 AM
varun added a child revision: D13232: [native][lib] Add RestoreUser RPCs to Identity client.Sep 6 2024, 9:51 AM
bartek updated this revision to Diff 43977.Sep 9 2024, 6:05 AM

Rebase

Harbormaster completed remote builds in B31491: Diff 43977.Sep 9 2024, 6:23 AM
kamil accepted this revision.Sep 10 2024, 5:51 AM
kamil added inline comments.
native/schema/CommRustModuleSchema.js
74 ↗(On Diff #43977)
This revision is now accepted and ready to land.Sep 10 2024, 5:51 AM
bartek updated this revision to Diff 44125.Sep 13 2024, 3:15 AM

Rename user_id to userID

Harbormaster completed remote builds in B31588: Diff 44125.Sep 13 2024, 3:32 AM
Closed by commit rCOMMe83c2a1be04e: [native] Add RestoreUser RPCs to JSI (authored by bartek). · Explain WhySep 13 2024, 3:36 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe83c2a1be04e: [native] Add RestoreUser RPCs to JSI.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
14 lines
65 lines
_generated/
schema/
14 lines

Diff 44134

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...