Page MenuHomePhabricator
Differential D13285

[lib] Support image avatars in DM thread-action
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 1:36 AM.
Tags
None
Referenced Files
F5099898: D13285.diff
Mon, Mar 31, 9:18 AM
F5096705: D13285.id44027.diff
Sun, Mar 30, 9:17 PM
Unknown Object (File)
Tue, Mar 25, 2:16 PM
Unknown Object (File)
Wed, Mar 5, 6:39 PM
Unknown Object (File)
Tue, Mar 4, 10:28 PM
Unknown Object (File)
Feb 26 2025, 11:35 AM
Unknown Object (File)
Feb 16 2025, 4:34 PM
Unknown Object (File)
Feb 15 2025, 9:30 PM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
tomek
inka
Commits
rCOMM20376feac450: [lib] Support image avatars in DM thread-action
Summary

Addresses 2. in ENG-9102.

Updated DM part of thread-actions.js to support new avatar type introduced in D13284

Depends on D13283, D13284

Test Plan

Tested in the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
actions/
14 lines

Diff 44165

View Options

lib/actions/thread-actions.js

// @flow // @flow
import { threadsStateSyncSpec as libSpec } from 'lib/shared/state-sync/threads-state-sync-spec.js'; import { threadsStateSyncSpec as libSpec } from 'lib/shared/state-sync/threads-state-sync-spec.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type RawThreadInfo, type RawThreadInfo,
rawThreadInfoValidator,
} from 'lib/types/thread-types.js'; } from 'lib/types/thread-types.js';
import { hash, combineUnorderedHashes, values } from 'lib/utils/objects.js';
import type { ServerStateSyncSpec } from './state-sync-spec.js'; import type { ServerStateSyncSpec } from './state-sync-spec.js';
import { fetchThreadInfos } from '../../fetchers/thread-fetchers.js'; import { fetchThreadInfos } from '../../fetchers/thread-fetchers.js';
import type { Viewer } from '../../session/viewer.js'; import type { Viewer } from '../../session/viewer.js';
import { validateOutput } from '../../utils/validation-utils.js';
export const threadsStateSyncSpec: ServerStateSyncSpec< export const threadsStateSyncSpec: ServerStateSyncSpec<
RawThreadInfos, RawThreadInfos,
RawThreadInfos, RawThreadInfos,
RawThreadInfo, RawThreadInfo,
> = Object.freeze({ > = Object.freeze({
async fetch(viewer: Viewer, ids?: $ReadOnlySet<string>) { async fetch(viewer: Viewer, ids?: $ReadOnlySet<string>) {
const filter = ids ? { threadIDs: ids } : undefined; const filter = ids ? { threadIDs: ids } : undefined;
const result = await fetchThreadInfos(viewer, filter); const result = await fetchThreadInfos(viewer, filter);
return result.threadInfos; return result.threadInfos;
}, },
async fetchFullSocketSyncPayload(viewer: Viewer) { async fetchFullSocketSyncPayload(viewer: Viewer) {
const result = await fetchThreadInfos(viewer); const result = await fetchThreadInfos(viewer);
return result.threadInfos; return result.threadInfos;
}, },
getServerInfosHash(infos: RawThreadInfos) {
return combineUnorderedHashes(values(infos).map(getServerInfoHash));
},
getServerInfoHash,
...libSpec, ...libSpec,
}); });
function getServerInfoHash(info: RawThreadInfo) {
return hash(validateOutput(null, rawThreadInfoValidator, info));
}