Paths

Table of Contentst

Differential D13405

[lib] Exclude users that don't support thick threads from results
ClosedPublic
Actions

Authored by tomek on Sep 20 2024, 4:55 AM.

Tags

None

Referenced Files

	F3299825: D13405.id44363.diff
	Sun, Nov 17, 3:47 PM

	Unknown Object (File)
	Fri, Nov 8, 1:42 AM

	Unknown Object (File)
	Fri, Nov 8, 1:42 AM

	Unknown Object (File)
	Fri, Nov 8, 1:33 AM

	Unknown Object (File)
	Fri, Oct 25, 2:37 AM

	Unknown Object (File)
	Oct 18 2024, 3:25 PM

	Unknown Object (File)
	Oct 12 2024, 9:03 AM

	Unknown Object (File)
	Oct 9 2024, 5:50 PM

View All 35 Files

Subscribers

Details

Reviewers

kamil
will

Commits

rCOMMb74fa444e9fb: [lib] Exclude users that don't support thick threads from results

Summary

When a user can't be added to thick thread, they shouldn't be included in search results.

https://linear.app/comm/issue/ENG-9257/limit-chat-candidates-to-users-who-are-registered-with-identity

Depends on D13404

Test Plan

Checked that the user who don't support thick threads aren't shown in add member modals of thick threads.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 20 2024, 4:55 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 4:55 AM

Harbormaster completed remote builds in B31733: Diff 44363.Sep 20 2024, 5:12 AM

tomek requested review of this revision.Sep 20 2024, 5:12 AM

ashoat added inline comments.Sep 20 2024, 6:05 AM

lib/shared/search-utils.js
166 ↗	(On Diff #44363)	In what cases is `threadType` not set here?

ashoat mentioned this in D13404: [lib] Create a thin thread when some users don't support thick threads.Sep 20 2024, 6:06 AM

tomek added inline comments.Sep 20 2024, 6:33 AM

lib/shared/search-utils.js
166 ↗	(On Diff #44363)	This happens in `chat-thread-composer.react.js` and `message-list-container.react.js` where we don't know what the resulting thread type would be. In these cases, we shouldn't filter out users who don't have CSAT because we're determining the thread thickness later, based on the presence of the CSAT.

ashoat added inline comments.Sep 20 2024, 6:43 AM

lib/shared/search-utils.js
166 ↗	(On Diff #44363)	Thanks for explaining!

kamil accepted this revision.Sep 20 2024, 6:58 AM

This revision is now accepted and ready to land.Sep 20 2024, 6:58 AM

Closed by commit rCOMMb74fa444e9fb: [lib] Exclude users that don't support thick threads from results (authored by tomek). · Explain WhySep 20 2024, 8:41 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMb74fa444e9fb: [lib] Exclude users that don't support thick threads from results.

inka mentioned this in D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.Oct 17 2024, 6:05 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

search-utils.js

48 lines

thread-actions-utils.js

7 lines

thread-utils.js

12 lines

native/

chat/

compose-subchannel.react.js

2 lines

message-list-container.react.js

2 lines

settings/

add-users-modal.react.js

2 lines

web/

chat/

chat-thread-composer.react.js

3 lines

settings/

relationship/

add-users-utils.js

4 lines

Diff 44398

lib/shared/search-utils.js

Loading...

lib/shared/thread-actions-utils.js

Loading...

lib/shared/thread-utils.js

Loading...

native/chat/compose-subchannel.react.js

Loading...

native/chat/message-list-container.react.js

Loading...

native/chat/settings/add-users-modal.react.js

Loading...

web/chat/chat-thread-composer.react.js

Loading...

web/settings/relationship/add-users-utils.js

Loading...