[lib] Avoid regenerating holdersToRemove whenever Redux state changes
ClosedPublic
Actions

Authored by ashoat on Sep 25 2024, 10:39 AM.

Details

Reviewers

bartek
kamil
tomek
varun
will

Commits

rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes

Summary

This diff addresses ENG-9391: Maximum update depth exceeded.

The way this code was written, whenever the Redux state changed, holdersToRemove would be regenerated. This led to a React render loop.

Test Plan

Confirm that the React render cycle goes away

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/updatedepth

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 25 2024, 10:39 AM

Harbormaster completed remote builds in B31848: Diff 44558.Sep 25 2024, 11:01 AM

ashoat requested review of this revision.Sep 25 2024, 11:01 AM

varun accepted this revision.Sep 25 2024, 11:29 AM

This revision is now accepted and ready to land.Sep 25 2024, 11:29 AM

Closed by commit rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes (authored by ashoat). · Explain WhySep 25 2024, 12:00 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes.

ashoat mentioned this in D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.Nov 7 2024, 5:13 AM

Revision Contents
Changeset List

Path

Size

lib/

actions/

holder-actions.js

11 lines

Diff 44558

View Options

lib/actions/holder-actions.js

[lib] Avoid regenerating holdersToRemove whenever Redux state changesClosedPublicActions