Page MenuHomePhabricator

[lib] Avoid regenerating holdersToRemove whenever Redux state changes
ClosedPublic

Authored by ashoat on Sep 25 2024, 10:39 AM.
Tags
None
Referenced Files
F3352468: D13465.id44558.diff
Sat, Nov 23, 6:03 AM
F3352293: D13465.id44564.diff
Sat, Nov 23, 5:26 AM
F3351563: D13465.diff
Sat, Nov 23, 2:31 AM
Unknown Object (File)
Sat, Nov 16, 7:58 PM
Unknown Object (File)
Sat, Nov 16, 4:02 PM
Unknown Object (File)
Fri, Nov 15, 1:02 PM
Unknown Object (File)
Tue, Nov 12, 1:20 PM
Unknown Object (File)
Fri, Nov 1, 9:30 PM
Subscribers
None

Details

Summary

This diff addresses ENG-9391: Maximum update depth exceeded.

The way this code was written, whenever the Redux state changed, holdersToRemove would be regenerated. This led to a React render loop.

Test Plan

Confirm that the React render cycle goes away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable