Page MenuHomePhabricator
Differential D13574

[native] undo changes that removed one time keys from identity v1 login calls
ClosedPublic
Actions

Authored by varun on Oct 2 2024, 8:54 AM.
Tags
None
Referenced Files
F3763457: D13574.id44826.diff
Sat, Jan 11, 4:09 AM
Unknown Object (File)
Tue, Dec 24, 12:40 AM
Unknown Object (File)
Tue, Dec 24, 12:40 AM
Unknown Object (File)
Tue, Dec 24, 12:40 AM
Unknown Object (File)
Tue, Dec 24, 12:40 AM
Unknown Object (File)
Tue, Dec 24, 12:40 AM
Unknown Object (File)
Mon, Dec 23, 12:25 PM
Unknown Object (File)
Mon, Dec 23, 7:35 AM
View All 48 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
will
Commits
rCOMMf865d5d62a59: [native] undo changes that removed one time keys from identity v1 login calls
Summary

we determined we actually want to send OTKs here because the device connecting to identity should have a fresh device ID, and therefore 0 pre-existing OTKs in DynamoDB.

https://linear.app/comm/issue/ENG-9440/clients-should-include-otks-on-first-login

Test Plan

log in to existing account from fresh simulator device, confirm that OTKs are present on DynamoDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
8 lines
16 lines
_generated/
identity-service/
32 lines
native_rust_library/
src/
identity/
8 lines
4 lines
schema/
4 lines

Diff 44826

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/native_rust_library/src/identity/login.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...