Page MenuHomePhabricator
Differential D13710

[native][web] Fix ENS resolution for local DM notifs
ClosedPublic
Actions

Authored by ashoat on Mon, Oct 14, 8:24 PM.
Tags
None
Referenced Files
F2990500: D13710.id45186.diff
Wed, Oct 16, 10:30 PM
F2990492: D13710.id45184.diff
Wed, Oct 16, 10:29 PM
F2989223: D13710.diff
Wed, Oct 16, 8:28 PM
Unknown Object (File)
Tue, Oct 15, 3:35 PM
Unknown Object (File)
Tue, Oct 15, 3:35 PM
Unknown Object (File)
Tue, Oct 15, 3:35 PM
Unknown Object (File)
Tue, Oct 15, 3:34 PM
Unknown Object (File)
Tue, Oct 15, 3:33 PM
View All 17 Files
Subscribers
None

Details

Reviewers
tomek
kamil
angelika
Commits
rCOMM03a6c519bfc5: [native][web] Fix ENS resolution for local DM notifs
Summary

ENSCacheProvider and NeynarClientProvider are relatively standalone components, and can safely be rendered higher in the tree.

On the other hand, TunnelbrokerProvider now handles notif sending, and as such is tightly coupled with business logic. We should render it lower in the hierarchy.

This diff solves ENG-9641 by making sure the DM notif-sending code in TunnelbrokerProvider is able to access the ENSCache in ENSCacheProvider, and the Farcaster username resolving code in NeynarClientProvider.

Test Plan

Confirmed that ENS resolution was working again for local DM notifs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Oct 14, 8:24 PM
ashoat added a comment.Mon, Oct 14, 8:25 PM
This comment was removed by ashoat.
ashoat published this revision for review.Mon, Oct 14, 8:25 PM

Going to land this one without review as it resolves an urgent issue

ashoat edited the summary of this revision. (Show Details)Mon, Oct 14, 8:26 PM
ashoat updated this revision to Diff 45186.Mon, Oct 14, 8:32 PM

Rebase

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Oct 14, 8:38 PM
This revision was landed with ongoing or failed builds.
Closed by commit rCOMM03a6c519bfc5: [native][web] Fix ENS resolution for local DM notifs (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM03a6c519bfc5: [native][web] Fix ENS resolution for local DM notifs.
Harbormaster completed remote builds in B32245: Diff 45184.Mon, Oct 14, 8:45 PM
Harbormaster completed remote builds in B32247: Diff 45186.Mon, Oct 14, 9:03 PM

Revision Contents
Changeset List

PathSize
native/
76 lines
web/
110 lines

Diff 45189

View Options

native/root.react.js

Loading...
View Options

web/app.react.js

Loading...