Page MenuHomePhabricator
Differential D13755

[keyserver] moving getting neynar config to function
ClosedPublic
Actions

Authored by will on Oct 20 2024, 10:00 PM.
Tags
None
Referenced Files
F3334769: D13755.diff
Thu, Nov 21, 7:46 AM
F3334598: D13755.id45550.diff
Thu, Nov 21, 7:15 AM
F3327212: D13755.diff
Wed, Nov 20, 8:30 AM
F3327211: D13755.id.diff
Wed, Nov 20, 8:29 AM
Unknown Object (File)
Mon, Nov 18, 3:58 AM
Unknown Object (File)
Mon, Nov 18, 3:03 AM
Unknown Object (File)
Sun, Nov 17, 3:35 AM
Unknown Object (File)
Sat, Nov 16, 2:26 PM
View All 48 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function
Summary

In the next diff, verifying the webhook event will require the webhook secret introduced in D13701. Moving grabbing the neynar config to a function to reduce code duplication

Depends on D13841

Test Plan

Later used in a future diff which successfully grabs the webhook secret

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 20 2024, 10:00 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 20 2024, 10:00 PM
will added a child revision: D13756: [keyserver] verify webhook event with webhook secret.Oct 20 2024, 10:03 PM
will edited the summary of this revision. (Show Details)Oct 20 2024, 10:04 PM
will added a parent revision: D13754: [keyserver] accept webhook cast created events tagging comm.
Harbormaster completed remote builds in B32311: Diff 45285.Oct 20 2024, 10:17 PM
will requested review of this revision.Oct 20 2024, 10:17 PM
ashoat accepted this revision.Oct 21 2024, 8:54 AM
ashoat added inline comments.
keyserver/src/utils/fc-cache.js
18–23

I wonder if this should be moved to a separate file. It doesn't really have to do with the FC cache

This revision is now accepted and ready to land.Oct 21 2024, 8:54 AM
will added inline comments.Mon, Oct 28, 2:06 PM
keyserver/src/utils/fc-cache.js
18–23

I think that makes sense. Decided to move it to a new file keyserver/src/utils/neynar-utils.js

will updated this revision to Diff 45413.Mon, Oct 28, 2:06 PM

move getNeynarConfig to own file

Harbormaster completed remote builds in B32391: Diff 45413.Mon, Oct 28, 2:24 PM
will edited parent revisions, added: D13841: [keyserver] add regex #createathread check; removed: D13754: [keyserver] accept webhook cast created events tagging comm.Thu, Oct 31, 7:15 AM
will edited the summary of this revision. (Show Details)
Closed by commit rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function (authored by will). · Explain WhyThu, Oct 31, 12:18 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
15 lines

Diff 45285

View Options

keyserver/src/utils/fc-cache.js

Loading...