Paths

Table of Contentst

-
keyserver/src/utils/
-
src/
-
utils/
-
fc-cache.js

[keyserver] moving getting neynar config to function
ClosedPublic
Actions

Authored by will on Oct 20 2024, 10:00 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function

Summary

In the next diff, verifying the webhook event will require the webhook secret introduced in D13701. Moving grabbing the neynar config to a function to reduce code duplication

Depends on D13841

Test Plan

Later used in a future diff which successfully grabs the webhook secret

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Oct 20 2024, 10:00 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 20 2024, 10:00 PM

will added a child revision: D13756: [keyserver] verify webhook event with webhook secret.Oct 20 2024, 10:03 PM

will edited the summary of this revision. (Show Details)Oct 20 2024, 10:04 PM

will added a parent revision: D13754: [keyserver] accept webhook cast created events tagging comm.

Harbormaster completed remote builds in B32311: Diff 45285.Oct 20 2024, 10:17 PM

will requested review of this revision.Oct 20 2024, 10:17 PM

ashoat accepted this revision.Oct 21 2024, 8:54 AM

ashoat added inline comments.

keyserver/src/utils/fc-cache.js
18–23	I wonder if this should be moved to a separate file. It doesn't really have to do with the FC cache

This revision is now accepted and ready to land.Oct 21 2024, 8:54 AM

will added inline comments.Oct 28 2024, 2:06 PM

keyserver/src/utils/fc-cache.js
18–23	I think that makes sense. Decided to move it to a new file `keyserver/src/utils/neynar-utils.js`

move getNeynarConfig to own file

Harbormaster completed remote builds in B32391: Diff 45413.Oct 28 2024, 2:24 PM

will edited parent revisions, added: D13841: [keyserver] add regex #createathread check; removed: D13754: [keyserver] accept webhook cast created events tagging comm.Oct 31 2024, 7:15 AM

will edited the summary of this revision. (Show Details)

Closed by commit rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function (authored by will). · Explain WhyOct 31 2024, 12:18 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

fc-cache.js

15 lines

Diff 45285

View Options

keyserver/src/utils/fc-cache.js

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
} from '../types/message-types.js';		} from '../types/message-types.js';
import type {		import type {
MinimallyEncodedRawThreadInfo,		MinimallyEncodedRawThreadInfo,
MinimallyEncodedThreadCurrentUserInfo,		MinimallyEncodedThreadCurrentUserInfo,
MinimallyEncodedThreadInfo,		MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';		} from '../types/minimally-encoded-thread-permissions-types.js';
import {		import {
decodeMinimallyEncodedRoleInfo,		decodeMinimallyEncodedRoleInfo,
		minimallyEncodeRawThreadInfo,
minimallyEncodeThreadInfo,		minimallyEncodeThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';		} from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import {		import {
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
configurableCommunityPermissions,		configurableCommunityPermissions,
type ThreadPermission,		type ThreadPermission,
▲ Show 20 Lines • Show All 655 Lines • ▼ Show 20 Lines	async function createRealThreadFromPendingThread({
return newThreadID;		return newThreadID;
}		}

type RawThreadInfoOptions = {		type RawThreadInfoOptions = {
+filterThreadEditAvatarPermission?: boolean,		+filterThreadEditAvatarPermission?: boolean,
+excludePinInfo?: boolean,		+excludePinInfo?: boolean,
+filterManageInviteLinksPermission?: boolean,		+filterManageInviteLinksPermission?: boolean,
+filterVoicedInAnnouncementChannelsPermission?: boolean,		+filterVoicedInAnnouncementChannelsPermission?: boolean,
		+minimallyEncodePermissions?: boolean,
};		};
function rawThreadInfoFromServerThreadInfo(		function rawThreadInfoFromServerThreadInfo(
serverThreadInfo: ServerThreadInfo,		serverThreadInfo: ServerThreadInfo,
viewerID: string,		viewerID: string,
options?: RawThreadInfoOptions,		options?: RawThreadInfoOptions,
): ?LegacyRawThreadInfo {		): ?RawThreadInfo {
const filterThreadEditAvatarPermission =		const filterThreadEditAvatarPermission =
options?.filterThreadEditAvatarPermission;		options?.filterThreadEditAvatarPermission;
const excludePinInfo = options?.excludePinInfo;		const excludePinInfo = options?.excludePinInfo;
const filterManageInviteLinksPermission =		const filterManageInviteLinksPermission =
options?.filterManageInviteLinksPermission;		options?.filterManageInviteLinksPermission;
const filterVoicedInAnnouncementChannelsPermission =		const filterVoicedInAnnouncementChannelsPermission =
options?.filterVoicedInAnnouncementChannelsPermission;		options?.filterVoicedInAnnouncementChannelsPermission;
		const shouldMinimallyEncodePermissions = options?.minimallyEncodePermissions;

const filterThreadPermissions = _omitBy(		const filterThreadPermissions = _omitBy(
(v, k) =>		(v, k) =>
(filterThreadEditAvatarPermission &&		(filterThreadEditAvatarPermission &&
[		[
threadPermissions.EDIT_THREAD_AVATAR,		threadPermissions.EDIT_THREAD_AVATAR,
threadPermissionPropagationPrefixes.DESCENDANT +		threadPermissionPropagationPrefixes.DESCENDANT +
threadPermissions.EDIT_THREAD_AVATAR,		threadPermissions.EDIT_THREAD_AVATAR,
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines	): ?RawThreadInfo {
const sourceMessageID = serverThreadInfo.sourceMessageID;		const sourceMessageID = serverThreadInfo.sourceMessageID;
if (sourceMessageID) {		if (sourceMessageID) {
rawThreadInfo = { ...rawThreadInfo, sourceMessageID };		rawThreadInfo = { ...rawThreadInfo, sourceMessageID };
}		}
if (serverThreadInfo.avatar) {		if (serverThreadInfo.avatar) {
rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };		rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };
}		}
if (!excludePinInfo) {		if (!excludePinInfo) {
return {		rawThreadInfo = {
...rawThreadInfo,		...rawThreadInfo,
pinnedCount: serverThreadInfo.pinnedCount,		pinnedCount: serverThreadInfo.pinnedCount,
};		};
}		}
return rawThreadInfo;		return shouldMinimallyEncodePermissions
		? minimallyEncodeRawThreadInfo(rawThreadInfo)
		: rawThreadInfo;
}		}

function threadUIName(threadInfo: ThreadInfo): string \| ThreadEntity {		function threadUIName(threadInfo: ThreadInfo): string \| ThreadEntity {
if (threadInfo.name) {		if (threadInfo.name) {
return firstLine(threadInfo.name);		return firstLine(threadInfo.name);
}		}

let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;		let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;
▲ Show 20 Lines • Show All 1,000 Lines • Show Last 20 Lines

[keyserver] moving getting neynar config to functionClosedPublicActions