Page MenuHomePhabricator
Differential D13798

[landing] Bump GitHub link to the front
ClosedPublic
Actions

Authored by ashoat on Oct 28 2024, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 2:16 AM
Unknown Object (File)
Wed, Apr 2, 4:34 PM
Unknown Object (File)
Wed, Apr 2, 6:42 AM
Unknown Object (File)
Tue, Apr 1, 6:41 AM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Feb 28 2025, 3:45 AM
Unknown Object (File)
Feb 28 2025, 3:44 AM
View All 52 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM92660e349d10: [landing] Bump GitHub link to the front
Summary

Given we have such a strong focus on being open source, I figure bumping the GitHub link earlier makes sense.

Depends on D13797

Test Plan

desktop

Screenshot 2024-10-28 at 3.42.02 PM.png (132×582 px, 8 KB)

mobile

Screenshot 2024-10-28 at 3.42.14 PM.png (586×374 px, 25 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/landing
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 28 2024, 12:39 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 28 2024, 12:39 PM
ashoat added a comment.Oct 28 2024, 12:41 PM

This diff looks complicated because Phabricator is highlighting it wrong. I just reordered the elements, moving the GitHub one before the Farcaster and Twitter ones

ashoat edited the test plan for this revision. (Show Details)Oct 28 2024, 12:42 PM
ashoat added a child revision: D13799: [landing] Remove invalid size prop in TeamProfile.Oct 28 2024, 12:52 PM
Harbormaster completed remote builds in B32387: Diff 45404.Oct 28 2024, 12:56 PM
ashoat requested review of this revision.Oct 28 2024, 12:56 PM
will accepted this revision.Oct 28 2024, 1:05 PM
This revision is now accepted and ready to land.Oct 28 2024, 1:05 PM
Closed by commit rCOMM92660e349d10: [landing] Bump GitHub link to the front (authored by ashoat). · Explain WhyOct 28 2024, 1:19 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM92660e349d10: [landing] Bump GitHub link to the front.

Revision Contents
Changeset List

PathSize
landing/
32 lines
12 lines

Diff 45404

View Options

landing/header.react.js

  • This file was added.
require 'json'
package = JSON.parse(File.read(File.join(__dir__, '..', 'package.json')))
Pod::Spec.new do |s|
s.name = 'Thumbhash'
s.version = package['version']
s.summary = package['description']
s.description = package['description']
s.license = package['license']
s.author = 'Comm'
s.homepage = 'https://comm.app'
s.platform = :ios, '13.0'
s.swift_version = '5.4'
s.source = { git: 'https://github.com/CommE2E/comm' }
s.static_framework = true
s.dependency 'ExpoModulesCore'
# Swift/Objective-C compatibility
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_COMPILATION_MODE' => 'wholemodule'
}
s.source_files = "**/*.{h,m,swift}"
end
View Options

landing/mobile-nav.react.js

  • This file was added.
require 'json'
package = JSON.parse(File.read(File.join(__dir__, '..', 'package.json')))
Pod::Spec.new do |s|
s.name = 'Thumbhash'
s.version = package['version']
s.summary = package['description']
s.description = package['description']
s.license = package['license']
s.author = 'Comm'
s.homepage = 'https://comm.app'
s.platform = :ios, '13.0'
s.swift_version = '5.4'
s.source = { git: 'https://github.com/CommE2E/comm' }
s.static_framework = true
s.dependency 'ExpoModulesCore'
# Swift/Objective-C compatibility
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_COMPILATION_MODE' => 'wholemodule'
}
s.source_files = "**/*.{h,m,swift}"
end