Details

Reviewers

ashoat
varun

Commits

rCOMM53a7aa8f514e: [keyserver] add the addViewerAsGhost option to createThread

Summary

This implements a addViewerAsGhost option to createThread. We use this in the context of farcaster bot to allow commbot to create threads without being added as a member.

Depends on D13811

Test Plan

Tested later in the stack. Confirmed that community threads and sidebar threads created by commbot did not have commbot visible in the members list.

Diff Detail

Repository

rCOMM Comm

Branch

add_ghost_creator

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Wed, Oct 30, 11:08 AM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Oct 30, 11:08 AM

will retitled this revision from [keyserver] add a addViewerAsGhost option to createThread to [keyserver] add the addViewerAsGhost option to createThread.Wed, Oct 30, 11:08 AM

rebase

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Wed, Oct 30, 11:10 AM

will mentioned this in D13813: [keyserver] remove commbot after creating community.Wed, Oct 30, 11:13 AM

Harbormaster completed remote builds in B32435: Diff 45468.Wed, Oct 30, 11:27 AM

Harbormaster completed remote builds in B32436: Diff 45469.

will requested review of this revision.Wed, Oct 30, 11:27 AM

ashoat accepted this revision.Wed, Oct 30, 12:02 PM

This revision is now accepted and ready to land.Wed, Oct 30, 12:02 PM

will added a child revision: D13832: [keyserver] do not filter by role in fetchCommunityInfos calls for script viewers.Wed, Oct 30, 12:31 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Wed, Oct 30, 1:31 PM

Closed by commit rCOMM53a7aa8f514e: [keyserver] add the addViewerAsGhost option to createThread (authored by will). · Explain WhyThu, Oct 31, 12:19 PM

This revision was automatically updated to reflect the committed changes.