Page MenuHomePhabricator
Differential D13819

[keyserver] add the addViewerAsGhost option to createThread
ClosedPublic
Actions

Authored by will on Oct 30 2024, 11:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 7:53 AM
Unknown Object (File)
Sun, Mar 23, 5:56 AM
Unknown Object (File)
Mon, Mar 17, 8:30 PM
Unknown Object (File)
Fri, Mar 14, 2:23 PM
Unknown Object (File)
Fri, Mar 14, 5:27 AM
Unknown Object (File)
Fri, Mar 14, 3:35 AM
Unknown Object (File)
Fri, Mar 14, 3:13 AM
Unknown Object (File)
Fri, Mar 14, 12:29 AM
View All 80 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM53a7aa8f514e: [keyserver] add the addViewerAsGhost option to createThread
Summary

This implements a addViewerAsGhost option to createThread. We use this in the context of farcaster bot to allow commbot to create threads without being added as a member.

Depends on D13811

Test Plan

Tested later in the stack. Confirmed that community threads and sidebar threads created by commbot did not have commbot visible in the members list.

Diff Detail

Repository
rCOMM Comm
Branch
add_ghost_creator
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 30 2024, 11:08 AM
Herald added a subscriber: tomek. · View Herald TranscriptOct 30 2024, 11:08 AM
will retitled this revision from [keyserver] add a addViewerAsGhost option to createThread to [keyserver] add the addViewerAsGhost option to createThread.Oct 30 2024, 11:08 AM
will updated this revision to Diff 45469.Oct 30 2024, 11:09 AM

rebase

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 11:10 AM
will mentioned this in D13813: [keyserver] remove commbot after creating community.Oct 30 2024, 11:13 AM
Harbormaster completed remote builds in B32435: Diff 45468.Oct 30 2024, 11:27 AM
Harbormaster completed remote builds in B32436: Diff 45469.
will requested review of this revision.Oct 30 2024, 11:27 AM
ashoat accepted this revision.Oct 30 2024, 12:02 PM
This revision is now accepted and ready to land.Oct 30 2024, 12:02 PM
will added a child revision: D13832: [keyserver] do not filter by role in fetchCommunityInfos calls for script viewers.Oct 30 2024, 12:31 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 1:31 PM
Closed by commit rCOMM53a7aa8f514e: [keyserver] add the addViewerAsGhost option to createThread (authored by will). · Explain WhyOct 31 2024, 12:19 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM53a7aa8f514e: [keyserver] add the addViewerAsGhost option to createThread.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
6 lines

Diff 45468

View Options

keyserver/src/creators/thread-creator.js

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linespub enum WorkflowInProgress {
Update(UpdateState), Update(UpdateState),
} }
#[derive(Clone, Serialize, Deserialize)] #[derive(Clone, Serialize, Deserialize)]
pub struct UserRegistrationInfo { pub struct UserRegistrationInfo {
pub username: String, pub username: String,
pub flattened_device_key_upload: FlattenedDeviceKeyUpload, pub flattened_device_key_upload: FlattenedDeviceKeyUpload,
pub user_id: Option<String>, pub user_id: Option<String>,
pub farcaster_id: Option<String>,
} }
#[derive(Clone, Serialize, Deserialize)] #[derive(Clone, Serialize, Deserialize)]
pub struct UserLoginInfo { pub struct UserLoginInfo {
pub user_id: String, pub user_id: String,
pub flattened_device_key_upload: FlattenedDeviceKeyUpload, pub flattened_device_key_upload: FlattenedDeviceKeyUpload,
pub opaque_server_login: comm_opaque2::server::Login, pub opaque_server_login: comm_opaque2::server::Login,
pub device_to_remove: Option<String>, pub device_to_remove: Option<String>,
▲ Show 20 Lines • Show All 52 Lines • ▼ Show 20 Lines ) -> Result<tonic::Response<RegistrationStartResponse>, tonic::Status> {
if RESERVED_USERNAME_SET.contains(&message.username) { if RESERVED_USERNAME_SET.contains(&message.username) {
return Err(tonic::Status::invalid_argument("username reserved")); return Err(tonic::Status::invalid_argument("username reserved"));
} }
let registration_state = construct_user_registration_info( let registration_state = construct_user_registration_info(
&message, &message,
None, None,
message.username.clone(), message.username.clone(),
message.farcaster_id.clone(),
)?; )?;
let server_registration = comm_opaque2::server::Registration::new(); let server_registration = comm_opaque2::server::Registration::new();
let server_message = server_registration let server_message = server_registration
.start( .start(
&CONFIG.server_setup, &CONFIG.server_setup,
&message.opaque_registration_request, &message.opaque_registration_request,
message.username.as_bytes(), message.username.as_bytes(),
) )
Show All 38 Lines let user_id = validate_account_ownership_message_and_get_user_id(
&message.keyserver_message, &message.keyserver_message,
&message.keyserver_signature, &message.keyserver_signature,
)?; )?;
let registration_state = construct_user_registration_info( let registration_state = construct_user_registration_info(
&message, &message,
Some(user_id), Some(user_id),
message.username.clone(), message.username.clone(),
None,
)?; )?;
let server_registration = comm_opaque2::server::Registration::new(); let server_registration = comm_opaque2::server::Registration::new();
let server_message = server_registration let server_message = server_registration
.start( .start(
&CONFIG.server_setup, &CONFIG.server_setup,
&message.opaque_registration_request, &message.opaque_registration_request,
message.username.as_bytes(), message.username.as_bytes(),
) )
▲ Show 20 Lines • Show All 357 Lines • ▼ Show 20 Lines let user_id = self
.client .client
.add_wallet_user_to_users_table( .add_wallet_user_to_users_table(
flattened_device_key_upload.clone(), flattened_device_key_upload.clone(),
wallet_address, wallet_address,
serialized_social_proof, serialized_social_proof,
None, None,
code_version, code_version,
login_time, login_time,
message.farcaster_id,
) )
.await .await
.map_err(handle_db_error)?; .map_err(handle_db_error)?;
// Create access token // Create access token
let token = AccessTokenData::with_created_time( let token = AccessTokenData::with_created_time(
user_id.clone(), user_id.clone(),
flattened_device_key_upload.device_id_key, flattened_device_key_upload.device_id_key,
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines self
.client .client
.add_wallet_user_to_users_table( .add_wallet_user_to_users_table(
flattened_device_key_upload.clone(), flattened_device_key_upload.clone(),
wallet_address, wallet_address,
serialized_social_proof, serialized_social_proof,
Some(user_id.clone()), Some(user_id.clone()),
code_version, code_version,
login_time, login_time,
None,
) )
.await .await
.map_err(handle_db_error)?; .map_err(handle_db_error)?;
let token = AccessTokenData::with_created_time( let token = AccessTokenData::with_created_time(
user_id.clone(), user_id.clone(),
flattened_device_key_upload.device_id_key, flattened_device_key_upload.device_id_key,
login_time, login_time,
▲ Show 20 Lines • Show All 337 Lines • ▼ Show 20 Lines match db_error {
} }
} }
} }
fn construct_user_registration_info( fn construct_user_registration_info(
message: &impl DeviceKeyUploadActions, message: &impl DeviceKeyUploadActions,
user_id: Option<String>, user_id: Option<String>,
username: String, username: String,
farcaster_id: Option<String>,
) -> Result<UserRegistrationInfo, tonic::Status> { ) -> Result<UserRegistrationInfo, tonic::Status> {
Ok(UserRegistrationInfo { Ok(UserRegistrationInfo {
username, username,
flattened_device_key_upload: construct_flattened_device_key_upload( flattened_device_key_upload: construct_flattened_device_key_upload(
message, message,
)?, )?,
user_id, user_id,
farcaster_id,
}) })
} }
fn construct_user_login_info( fn construct_user_login_info(
user_id: String, user_id: String,
opaque_server_login: comm_opaque2::server::Login, opaque_server_login: comm_opaque2::server::Login,
flattened_device_key_upload: FlattenedDeviceKeyUpload, flattened_device_key_upload: FlattenedDeviceKeyUpload,
device_to_remove: Option<String>, device_to_remove: Option<String>,
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines