[keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole
ClosedPublic
Actions

Authored by will on Oct 30 2024, 12:45 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for…

Summary

Using fetchThreadInfos in updateRole with the commbot ghost viewer results in the request's thread being filtered out. We instead use fetchServerThreadInfos instead here to avoid filtering based on the viewer

Depends on D13832

Test Plan

No longer received ServerError: invalid_parameters later in stack when attempting to create a farcaster channel community with farcaster bot and updating role with commbot as viewer

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Oct 30 2024, 12:45 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 30 2024, 12:45 PM

will added a child revision: D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.Oct 30 2024, 1:00 PM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 1:31 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.

Harbormaster completed remote builds in B32450: Diff 45483.Oct 30 2024, 1:36 PM

will requested review of this revision.Oct 30 2024, 1:36 PM

ashoat accepted this revision.Oct 30 2024, 2:40 PM

This revision is now accepted and ready to land.Oct 30 2024, 2:40 PM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 6:10 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 7:17 AM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 9:25 AM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 12:07 PM

Closed by commit rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for… (authored by will). · Explain WhyOct 31 2024, 12:19 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

thread-updaters.js

2 lines

Diff 45483

View Options

keyserver/src/updaters/thread-updaters.js

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
} from '../types/message-types.js';		} from '../types/message-types.js';
import type {		import type {
MinimallyEncodedRawThreadInfo,		MinimallyEncodedRawThreadInfo,
MinimallyEncodedThreadCurrentUserInfo,		MinimallyEncodedThreadCurrentUserInfo,
MinimallyEncodedThreadInfo,		MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';		} from '../types/minimally-encoded-thread-permissions-types.js';
import {		import {
decodeMinimallyEncodedRoleInfo,		decodeMinimallyEncodedRoleInfo,
		minimallyEncodeRawThreadInfo,
minimallyEncodeThreadInfo,		minimallyEncodeThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';		} from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import {		import {
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
configurableCommunityPermissions,		configurableCommunityPermissions,
type ThreadPermission,		type ThreadPermission,
▲ Show 20 Lines • Show All 655 Lines • ▼ Show 20 Lines	async function createRealThreadFromPendingThread({
return newThreadID;		return newThreadID;
}		}

type RawThreadInfoOptions = {		type RawThreadInfoOptions = {
+filterThreadEditAvatarPermission?: boolean,		+filterThreadEditAvatarPermission?: boolean,
+excludePinInfo?: boolean,		+excludePinInfo?: boolean,
+filterManageInviteLinksPermission?: boolean,		+filterManageInviteLinksPermission?: boolean,
+filterVoicedInAnnouncementChannelsPermission?: boolean,		+filterVoicedInAnnouncementChannelsPermission?: boolean,
		+minimallyEncodePermissions?: boolean,
};		};
function rawThreadInfoFromServerThreadInfo(		function rawThreadInfoFromServerThreadInfo(
serverThreadInfo: ServerThreadInfo,		serverThreadInfo: ServerThreadInfo,
viewerID: string,		viewerID: string,
options?: RawThreadInfoOptions,		options?: RawThreadInfoOptions,
): ?LegacyRawThreadInfo {		): ?RawThreadInfo {
const filterThreadEditAvatarPermission =		const filterThreadEditAvatarPermission =
options?.filterThreadEditAvatarPermission;		options?.filterThreadEditAvatarPermission;
const excludePinInfo = options?.excludePinInfo;		const excludePinInfo = options?.excludePinInfo;
const filterManageInviteLinksPermission =		const filterManageInviteLinksPermission =
options?.filterManageInviteLinksPermission;		options?.filterManageInviteLinksPermission;
const filterVoicedInAnnouncementChannelsPermission =		const filterVoicedInAnnouncementChannelsPermission =
options?.filterVoicedInAnnouncementChannelsPermission;		options?.filterVoicedInAnnouncementChannelsPermission;
		const shouldMinimallyEncodePermissions = options?.minimallyEncodePermissions;

const filterThreadPermissions = _omitBy(		const filterThreadPermissions = _omitBy(
(v, k) =>		(v, k) =>
(filterThreadEditAvatarPermission &&		(filterThreadEditAvatarPermission &&
[		[
threadPermissions.EDIT_THREAD_AVATAR,		threadPermissions.EDIT_THREAD_AVATAR,
threadPermissionPropagationPrefixes.DESCENDANT +		threadPermissionPropagationPrefixes.DESCENDANT +
threadPermissions.EDIT_THREAD_AVATAR,		threadPermissions.EDIT_THREAD_AVATAR,
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines	): ?RawThreadInfo {
const sourceMessageID = serverThreadInfo.sourceMessageID;		const sourceMessageID = serverThreadInfo.sourceMessageID;
if (sourceMessageID) {		if (sourceMessageID) {
rawThreadInfo = { ...rawThreadInfo, sourceMessageID };		rawThreadInfo = { ...rawThreadInfo, sourceMessageID };
}		}
if (serverThreadInfo.avatar) {		if (serverThreadInfo.avatar) {
rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };		rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };
}		}
if (!excludePinInfo) {		if (!excludePinInfo) {
return {		rawThreadInfo = {
...rawThreadInfo,		...rawThreadInfo,
pinnedCount: serverThreadInfo.pinnedCount,		pinnedCount: serverThreadInfo.pinnedCount,
};		};
}		}
return rawThreadInfo;		return shouldMinimallyEncodePermissions
		? minimallyEncodeRawThreadInfo(rawThreadInfo)
		: rawThreadInfo;
}		}

function threadUIName(threadInfo: ThreadInfo): string \| ThreadEntity {		function threadUIName(threadInfo: ThreadInfo): string \| ThreadEntity {
if (threadInfo.name) {		if (threadInfo.name) {
return firstLine(threadInfo.name);		return firstLine(threadInfo.name);
}		}

let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;		let threadMembers: $ReadOnlyArray<RelativeMemberInfo>;
▲ Show 20 Lines • Show All 1,000 Lines • Show Last 20 Lines

[keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRoleClosedPublicActions