[keyserver] return status code from blob download function
ClosedPublic
Actions

Authored by will on Oct 22 2024, 9:04 PM.

Details

Reviewers

varun
bartek
ashoat

Commits

rCOMM7fe438a0da72: [keyserver] return status code from blob download function

Summary

In order to check if the blob service has a farcaster channel tag blob or not, we need the status code to determine if it was a 404.

Depends on D13762

Test Plan

flow check. Tested this later in the stack by checking the status code

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Oct 22 2024, 9:04 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 22 2024, 9:04 PM

Harbormaster completed remote builds in B32342: Diff 45331.Oct 22 2024, 9:22 PM

will requested review of this revision.Oct 22 2024, 9:22 PM

will added a child revision: D13774: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator.Oct 22 2024, 9:24 PM

ashoat accepted this revision.Oct 23 2024, 5:37 AM

This revision is now accepted and ready to land.Oct 23 2024, 5:37 AM

Closed by commit rCOMM7fe438a0da72: [keyserver] return status code from blob download function (authored by will). · Explain WhyOct 31 2024, 12:19 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM7fe438a0da72: [keyserver] return status code from blob download function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

blob.js

3 lines

Diff 45553

View Options

keyserver/src/services/blob.js

[keyserver] return status code from blob download functionClosedPublicActions