Page MenuHomePhabricator

[keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole
ClosedPublic

Authored by will on Oct 30 2024, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 9:54 PM
Unknown Object (File)
Mon, Dec 16, 9:54 PM
Unknown Object (File)
Mon, Dec 16, 9:54 PM
Unknown Object (File)
Mon, Dec 16, 9:53 PM
Unknown Object (File)
Fri, Nov 29, 7:08 AM
Unknown Object (File)
Fri, Nov 29, 5:02 AM
Unknown Object (File)
Fri, Nov 29, 1:10 AM
Unknown Object (File)
Thu, Nov 28, 11:13 PM
Subscribers

Details

Summary

Using fetchThreadInfos in updateRole with the commbot ghost viewer results in the request's thread being filtered out. We instead use fetchServerThreadInfos instead here to avoid filtering based on the viewer

Depends on D13832

Test Plan

No longer received ServerError: invalid_parameters later in stack when attempting to create a farcaster channel community with farcaster bot and updating role with commbot as viewer

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Oct 30 2024, 1:36 PM
This revision is now accepted and ready to land.Oct 30 2024, 2:40 PM