Page MenuHomePhabricator
Differential D13892

[native][web] Clean up dead conditions for media encryption
ClosedPublic
Actions

Authored by bartek on Thu, Nov 7, 3:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 7:04 AM
Unknown Object (File)
Thu, Nov 21, 6:53 AM
Unknown Object (File)
Thu, Nov 21, 4:04 AM
Unknown Object (File)
Tue, Nov 19, 3:07 AM
Unknown Object (File)
Tue, Nov 19, 2:25 AM
Unknown Object (File)
Tue, Nov 19, 1:36 AM
Unknown Object (File)
Mon, Nov 18, 7:49 PM
Unknown Object (File)
Mon, Nov 18, 2:16 PM
View All 38 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM95e169f5657f: [native][web] Clean up dead conditions for media encryption
Summary

In D13890 and D13891 some hardcoded switches were flipped, producing a dead code.
Removed unnecessary conditions and simplified code a bit.

Depends on D13891

Test Plan

Flow, eslint, test plans from D13890, D13891 to check for regressions

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Nov 7, 3:46 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 7, 3:46 AM
Harbormaster failed remote builds in B32572: Diff 45659!Thu, Nov 7, 3:53 AM
bartek updated this revision to Diff 45686.Thu, Nov 7, 4:28 AM

Commit missing line

Harbormaster completed remote builds in B32575: Diff 45686.Thu, Nov 7, 4:47 AM
bartek published this revision for review.Thu, Nov 7, 4:50 AM
bartek mentioned this in D13890: [native][web] Stop limiting media encryption to staff community.
bartek mentioned this in D13891: [native][web] Flip the switch for blob-hosted media/avatar uploads.
bartek added inline comments.
web/input/input-state-container.react.js
917–920 ↗(On Diff #45686)

Technically, now upload type should be always encrypted_{photo,video}, so we could remove the else branch and use invariant here

ashoat accepted this revision.Thu, Nov 7, 5:35 AM

It seems like we can delete commStaffCommunity and threadInfoInsideCommunity from the codebase as well. What do you think?

web/input/input-state-container.react.js
917–920 ↗(On Diff #45686)

I think that would be a good idea. It's better to get rid of this "dead code" and simplify InputStateContainer. Can you make those changes on both native and web before landing?

This revision is now accepted and ready to land.Thu, Nov 7, 5:35 AM
bartek added inline comments.Thu, Nov 7, 7:23 AM
web/input/input-state-container.react.js
917–920 ↗(On Diff #45686)

Sure! I'll do this

ashoat added inline comments.Thu, Nov 7, 7:09 PM
web/input/input-state-container.react.js
917–920 ↗(On Diff #45686)

Great – just making sure you didn't miss that I requested to delete commStaffCommunity and threadInfoInsideCommunity as well

bartek updated this revision to Diff 45717.Fri, Nov 8, 5:29 AM

Rebase, add invariants for encrypted uploads, remove more dead code: legacy calls

ashoat added a comment.Fri, Nov 8, 5:34 AM

There's now an increasingly long list of "dangling" functions/types that can be removed:

  • commStaffCommunity
  • threadInfoInsideCommunity
  • uploadMultimedia
  • MultimediaUploadExtras

Can you make sure to remove all of these before landing?

bartek updated this revision to Diff 45726.EditedFri, Nov 8, 8:16 AM

I was going to create a separate diff for removing the 'uploadMultimedia' but decided to fixup it into this one

In D13892#388173, @ashoat wrote:

There's now an increasingly long list of "dangling" functions/types that can be removed:

  • commStaffCommunity
  • threadInfoInsideCommunity
  • uploadMultimedia
  • MultimediaUploadExtras

Can you make sure to remove all of these before landing?

They're all now removed in this diff

Harbormaster completed remote builds in B32597: Diff 45726.Fri, Nov 8, 8:41 AM
ashoat accepted this revision.Fri, Nov 8, 8:50 AM

Thank you!! (Separate diff would've been fine – didn't mean to imply that it had to be in the same diff)

Closed by commit rCOMM95e169f5657f: [native][web] Clean up dead conditions for media encryption (authored by bartek). · Explain WhyFri, Nov 8, 10:23 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM95e169f5657f: [native][web] Clean up dead conditions for media encryption.

Revision Contents
Changeset List

PathSize
native/
avatars/
29 lines
input/
249 lines
web/
avatars/
21 lines
input/
138 lines
1 line

Diff 45717

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/avatars/avatar-hooks.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...