Page MenuHomePhabricator
Differential D14116

[native] navigate to proper screen after scanning QR code
Needs ReviewPublic
Actions

Authored by kamil on Wed, Dec 11, 8:17 AM.

Details

Reviewers
ashoat
tomek
Summary

ENG-9959.

Navigates to screen implemented in previous diffs in the stack, right after the QR code is scanned.

Adds useFocusEffect because after swiping back to the camera user should be able to scan the QR again.

In ENG-9968 there is an example of how this flow looks like

Depends on D14115

Test Plan

Test this on both secondary and primary, full flow should work.

After swiping back to the camera, the user can scan the QR code again.

Diff Detail

Repository
rCOMM Comm
Branch
qr-work
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Dec 11, 8:17 AM
kamil held this revision as a draft.
kamil edited the summary of this revision. (Show Details)Wed, Dec 11, 8:25 AM
kamil added inline comments.
native/account/qr-auth/secondary-device-qr-code-scanner.react.js
63

this is only for emulator but looks like we could also check if device is primary

kamil edited the summary of this revision. (Show Details)Wed, Dec 11, 8:26 AM
kamil edited the test plan for this revision. (Show Details)
kamil published this revision for review.Wed, Dec 11, 8:30 AM
Harbormaster completed remote builds in B33016: Diff 46334.Wed, Dec 11, 10:09 AM

Revision Contents
Changeset List

PathSize
native/
account/
qr-auth/
55 lines

Diff 46334

View Options

native/account/qr-auth/secondary-device-qr-code-scanner.react.js

Loading...