[native] Migrate TextMessageTooltipButton to Reanimated V2 API
ClosedPublic
Actions

Authored by angelika on Dec 11 2024, 8:50 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM224ab8302118: [native] Migrate TextMessageTooltipButton to Reanimated V2 API

Summary

A straightforward migration: use progressV2 shared value, use useAnimatedStyle instead of useMemo and put interpolate in a worklet.

Depends on D14121

Test Plan

Open up text message tooltip and verify it's animated correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Dec 11 2024, 8:50 AM

angelika held this revision as a draft.

angelika added a child revision: D14123: [native] Migrate TooltipInlineEngagement to Reanimated V2 API.Dec 11 2024, 10:36 AM

Harbormaster completed remote builds in B33022: Diff 46340.Dec 11 2024, 11:11 AM

angelika published this revision for review.Dec 11 2024, 5:27 PM

ashoat accepted this revision.Dec 11 2024, 7:54 PM

This revision is now accepted and ready to land.Dec 11 2024, 7:54 PM

Rebase and address feedback

Harbormaster completed remote builds in B33094: Diff 46416.Dec 13 2024, 8:04 AM

Rebase

Harbormaster completed remote builds in B33138: Diff 46479.Dec 16 2024, 8:58 AM

Closed by commit rCOMM224ab8302118: [native] Migrate TextMessageTooltipButton to Reanimated V2 API (authored by angelika). · Explain WhyDec 16 2024, 1:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM224ab8302118: [native] Migrate TextMessageTooltipButton to Reanimated V2 API.

Revision Contents
Changeset List

Path

Size

native/

chat/

text-message-tooltip-button.react.js

23 lines

Diff 46340

View Options

native/chat/text-message-tooltip-button.react.js

[native] Migrate TextMessageTooltipButton to Reanimated V2 APIClosedPublicActions