Page MenuHomePhabricator
Differential D14104

[native] Move margin getter in Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 7:34 AM.
Tags
None
Referenced Files
F3492389: D14104.diff
Wed, Dec 18, 11:38 PM
Unknown Object (File)
Tue, Dec 17, 3:26 PM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component
Summary

Simply move get margin function to functional component as a part of Tooltip migration to functional component.

Depends on: D14103

Test Plan

Open some tooltips and verify they're positioned correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 7:34 AM
angelika held this revision as a draft.
angelika edited the summary of this revision. (Show Details)Wed, Dec 11, 7:35 AM
angelika added a parent revision: D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API.
angelika added a child revision: D14106: [native] Move tooltip height getter in Tooltip to functional component.Wed, Dec 11, 7:37 AM
Harbormaster completed remote builds in B33004: Diff 46322.Wed, Dec 11, 8:08 AM
angelika published this revision for review.Wed, Dec 11, 4:53 PM
ashoat accepted this revision.Wed, Dec 11, 5:43 PM
ashoat added inline comments.
native/tooltip/tooltip.react.js
559–564 ↗(On Diff #46322)

I would make this a memo and replace the getter with the value itself. (Feel free to address this later in the stack)

This revision is now accepted and ready to land.Wed, Dec 11, 5:43 PM
angelika updated this revision to Diff 46402.Fri, Dec 13, 5:29 AM

Rebase and address feedback

Harbormaster completed remote builds in B33080: Diff 46402.Fri, Dec 13, 6:07 AM
angelika marked an inline comment as done.Fri, Dec 13, 6:08 AM
angelika updated this revision to Diff 46465.Mon, Dec 16, 6:19 AM

Rebase

Harbormaster completed remote builds in B33124: Diff 46465.Mon, Dec 16, 7:02 AM
Closed by commit rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM0691b0b4964c: [native] Move margin getter in Tooltip to functional component.

Revision Contents
Changeset List

PathSize
native/
tooltip/
31 lines

Diff 46402

View Options

native/tooltip/tooltip.react.js

Loading...