Page MenuHomePhabricator
Differential D14118

[native] Add progressV2 field to tooltip button types
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 8:29 AM.
Tags
None
Referenced Files
F3507231: D14118.diff
Fri, Dec 20, 7:50 PM
F3506897: D14118.id46511.diff
Fri, Dec 20, 6:33 PM
F3506041: D14118.id46412.diff
Fri, Dec 20, 3:32 PM
F3499072: D14118.id.diff
Thu, Dec 19, 10:26 PM
F3497964: D14118.id46475.diff
Thu, Dec 19, 8:23 PM
F3497820: D14118.id46413.diff
Thu, Dec 19, 7:59 PM
Unknown Object (File)
Wed, Dec 18, 2:04 PM
Unknown Object (File)
Wed, Dec 18, 1:22 PM
View All 12 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMfe8f09cc3e44: [native] Add progressV2 field to tooltip button types
Summary

This diff only adds progressV2 field to tooltip button types. I'm doing it as a separate diff, because it touches several files at once.

Depends on D14117

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 8:29 AM
angelika held this revision as a draft.
angelika added a child revision: D14119: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to Reanimate V2 API.Wed, Dec 11, 8:33 AM
Harbormaster completed remote builds in B33018: Diff 46336.Wed, Dec 11, 10:29 AM
angelika published this revision for review.Wed, Dec 11, 5:26 PM
ashoat accepted this revision.Wed, Dec 11, 7:50 PM
This revision is now accepted and ready to land.Wed, Dec 11, 7:50 PM
ashoat added a comment.Wed, Dec 11, 7:50 PM

Thanks for separating this out!

angelika updated this revision to Diff 46412.Fri, Dec 13, 5:35 AM

Rebase and address feedback

Harbormaster completed remote builds in B33090: Diff 46412.Fri, Dec 13, 7:32 AM
angelika updated this revision to Diff 46475.Mon, Dec 16, 6:22 AM

Rebase

Harbormaster completed remote builds in B33134: Diff 46475.Mon, Dec 16, 8:23 AM
Closed by commit rCOMMfe8f09cc3e44: [native] Add progressV2 field to tooltip button types (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMfe8f09cc3e44: [native] Add progressV2 field to tooltip button types.

Revision Contents
Changeset List

Diff 46412

View Options

native/chat/multimedia-message-tooltip-button.react.js

Loading...
View Options

native/chat/robotext-message-tooltip-button.react.js

Loading...
View Options

native/chat/text-message-tooltip-button.react.js

Loading...
View Options

native/chat/utils.js

Loading...
View Options

native/tooltip/tooltip.react.js

Loading...